Skip to content

[Docs] Vcpkg via FetchContent#27158

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
jpr42:patch-1
Oct 14, 2022
Merged

[Docs] Vcpkg via FetchContent#27158
vicroms merged 1 commit intomicrosoft:masterfrom
jpr42:patch-1

Conversation

@jpr42
Copy link
Contributor

@jpr42 jpr42 commented Oct 9, 2022

Show how to easily incorporate vcpkg into a CMake project without git submodules

@jpr42
Copy link
Contributor Author

jpr42 commented Oct 9, 2022

@microsoft-github-policy-service agree

@Cheney-W
Copy link
Contributor

Please add - [Vcpkg via FetchContent](#vcpkg-via-FetchContent) into the line 36.

@Cheney-W Cheney-W changed the title Vcpkg via FetchContent [Docs] Vcpkg via FetchContent Oct 10, 2022
@Cheney-W Cheney-W added category:documentation To resolve the issue, documentation will need to be updated requires:author-response labels Oct 10, 2022
@jpr42
Copy link
Contributor Author

jpr42 commented Oct 11, 2022

I changed the cmake min to 3.14 since that's when FetchContent_MakeAvailable was introduced.

@jpr42 jpr42 requested review from Neumann-A and autoantwort and removed request for autoantwort October 12, 2022 00:14
@jpr42
Copy link
Contributor Author

jpr42 commented Oct 12, 2022

I think this PR looks good now based on the feedback

Show how to easily incorporate vcpkg into a CMake project without git submodules
@Cheney-W Cheney-W added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Oct 12, 2022
@jpr42 jpr42 requested review from Cheney-W and removed request for Neumann-A October 13, 2022 01:06
@jpr42
Copy link
Contributor Author

jpr42 commented Oct 14, 2022

Looks like everything is good now. Is there anything else I need to sort out?

@vicroms vicroms merged commit aed63d2 into microsoft:master Oct 14, 2022
@jpr42 jpr42 deleted the patch-1 branch October 15, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:documentation To resolve the issue, documentation will need to be updated info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants