Skip to content

[ogre] Update to 13.4.4#27107

Merged
vicroms merged 11 commits intomicrosoft:masterfrom
dg0yt:ogre-13.4.4
Oct 13, 2022
Merged

[ogre] Update to 13.4.4#27107
vicroms merged 11 commits intomicrosoft:masterfrom
dg0yt:ogre-13.4.4

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 5, 2022

(Including squashed commits from #26938)

  • What does your PR fix?

    Resolves [ogre] update to 13.3.4 #24984.
    Fixes [ogre] Build error on x64-osx #22597.
    Changes installation layout to use per build-type etc/ogre (for config) and plugins/ogre, and to use share/ogre for common stuff.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    fixes osx, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

  • Known issues

    • Upstream limitation (won't fix): There is vendored copy of miniz. It cannot be unvendored easily because ogre usage relies on private functions.
    • Upstream limitation (won't fix): The pkg-config files probably lack some transitive usage requirements.
    • Port limitation: For linux etc., the port requires the Xaw system library. However, apart from upstream's pc file template, it isn't strictly necessary.

github-actions[bot]
github-actions bot previously approved these changes Oct 5, 2022
@autoantwort
Copy link
Contributor

#22597 (comment) Did an update fixed this issue?

github-actions[bot]
github-actions bot previously approved these changes Oct 5, 2022
@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 5, 2022

#22597 (comment) Did an update fixed this issue?

The bug was fixed upstream in OGRECave/ogre@84ae939.
But the immediate solution for vcpkg was setting -DOGRE_BUILD_LIBS_AS_FRAMEWORKS=OFF which disabled the broken section.

github-actions[bot]
github-actions bot previously approved these changes Oct 5, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 6, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 6, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 8, 2022
JonLiu1993
JonLiu1993 previously approved these changes Oct 9, 2022
@JonLiu1993
Copy link
Contributor

@dg0yt, Thanks for your pr, when I tested the features by command "./vcpkg install ogre[*]:x86-windows",
I got this error, please take a look:

CMake Error at F:/Feature-test/orge/vcpkg/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find SWIG (missing: SWIG_EXECUTABLE SWIG_DIR) (Required is at
  least version "3.0.8")
Call Stack (most recent call first):

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 10, 2022

@dg0yt, Thanks for your pr, when I tested the features by command "./vcpkg install ogre[*]:x86-windows", I got this error, please take a look:

CMake Error at F:/Feature-test/orge/vcpkg/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find SWIG (missing: SWIG_EXECUTABLE SWIG_DIR) (Required is at
  least version "3.0.8")
Call Stack (most recent call first):

Because you don't have swig installed. It is not a regression.
(I could add vcpkg_find_acquire_program(SWIG) but I cannot test it for windows triplets.)

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 11, 2022

I added vcpkg_find_acquire_program(SWIG) to portfile.cmake file, but got this error, I can help you test it.

CMake Error at CMakeLists.txt:19 (vcpkg_find_acquire_program):
  Unknown CMake command "vcpkg_find_acquire_program".

Please think twice.

@JonLiu1993
Copy link
Contributor

I added vcpkg_find_acquire_program(SWIG) to portfile.cmake file, but got this error, I can help you test it.

CMake Error at CMakeLists.txt:19 (vcpkg_find_acquire_program):
  Unknown CMake command "vcpkg_find_acquire_program".

Please think twice.

Sorry, I forget I have added this to CMakeLists.txt file, I remove vcpkg_find_acquire_program(SWIG) code in CMakeLists.txt file, and tested again, but also can't find SWIG

CMake Error at F:/Feature-test/orge/vcpkg/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find SWIG (missing: SWIG_EXECUTABLE SWIG_DIR) (Required is at
  least version "3.0.8")
Call Stack (most recent call first):

@dg0yt dg0yt dismissed stale reviews from JonLiu1993 and github-actions[bot] via 11ba8c5 October 11, 2022 18:27
@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 11, 2022

missing: SWIG_EXECUTABLE

This tells us what to do with SWIG.

@JonLiu1993
Copy link
Contributor

@dg0yt, The above error is solved, but a new error is encountered,

CMake Error at F:/Feature-test/orge/vcpkg/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/CMakeDetermineCSharpCompiler.cmake:5 (message):
  C# is currently only supported for Microsoft Visual Studio 2010 and later.
Call Stack (most recent call first):
  Components/Csharp/CMakeLists.txt:8 (enable_language)


CMake Error: CMAKE_CSharp_COMPILER not set, after EnableLanguage

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 12, 2022

Certainly not a regression. I'm not going to fix it.

@JonLiu1993
Copy link
Contributor

Certainly not a regression. I'm not going to fix it.

It is difficult for these features to be successfully tested locally

@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Oct 12, 2022
@vicroms vicroms merged commit 1019317 into microsoft:master Oct 13, 2022
@dg0yt dg0yt deleted the ogre-13.4.4 branch October 13, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ogre] update to 13.3.4 [ogre] Build error on x64-osx

4 participants