Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boringssl] Add pkg-config file so it still works with gRPC #27082

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Oct 3, 2022

Describe the pull request

  • What does your PR fix?

Fixes failure to be able to build gRPC against boringssl (after adjusting the grpc dependencies). This used to work before a recent gRPC update in vcpkg, this makes it work again.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Have only tested on Linux but it should work on Windows too. Did not update CI baseline

yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout aa27f5d15ab1d8cb1617d1c003d1b4a30e472e24 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/boringssl.json b/versions/b-/boringssl.json
index 4f560ea..893c242 100644
--- a/versions/b-/boringssl.json
+++ b/versions/b-/boringssl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "cb83700b7bf53177773421dfb803fb8478e6a72d",
+      "version-date": "2021-06-23",
+      "port-version": 3
+    },
     {
       "git-tree": "8d28c72d322cf2245e69075deef73c5edefee0b5",
       "version-date": "2021-06-23",
diff --git a/versions/baseline.json b/versions/baseline.json
index 17d8567..c2ed89a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1162,7 +1162,7 @@
     },
     "boringssl": {
       "baseline": "2021-06-23",
-      "port-version": 2
+      "port-version": 3
     },
     "botan": {
       "baseline": "2.19.1",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/boringssl/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/boringssl/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY self-assigned this Oct 8, 2022
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 8, 2022
@JackBoosY
Copy link
Contributor

Did you test the usage?

@rpavlik
Copy link
Contributor Author

rpavlik commented Oct 8, 2022

Yes I have tested it.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 9, 2022
@vicroms vicroms merged commit 125df1b into microsoft:master Oct 9, 2022
@rpavlik rpavlik deleted the boringssl-pkgconfig branch October 10, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants