-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boringssl] Add pkg-config file so it still works with gRPC #27082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout aa27f5d15ab1d8cb1617d1c003d1b4a30e472e24 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/boringssl.json b/versions/b-/boringssl.json
index 4f560ea..893c242 100644
--- a/versions/b-/boringssl.json
+++ b/versions/b-/boringssl.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "cb83700b7bf53177773421dfb803fb8478e6a72d",
+ "version-date": "2021-06-23",
+ "port-version": 3
+ },
{
"git-tree": "8d28c72d322cf2245e69075deef73c5edefee0b5",
"version-date": "2021-06-23",
diff --git a/versions/baseline.json b/versions/baseline.json
index 17d8567..c2ed89a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1162,7 +1162,7 @@
},
"boringssl": {
"baseline": "2021-06-23",
- "port-version": 2
+ "port-version": 3
},
"botan": {
"baseline": "2.19.1",
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/boringssl/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/boringssl/vcpkg.json
Valid values for the license field can be found in the documentation
Did you test the usage? |
Yes I have tested it. |
Describe the pull request
What does your PR fix?
Fixes failure to be able to build gRPC against boringssl (after adjusting the grpc dependencies). This used to work before a recent gRPC update in vcpkg, this makes it work again.
Which triplets are supported/not supported? Have you updated the CI baseline?
Have only tested on Linux but it should work on Windows too. Did not update CI baseline
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes