[ignition-tools] new port #27078
Merged
[ignition-tools] new port #27078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to solve it: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
@JackBoosY @dg0yt |
|
This is a command line tool without headers that the sdforamt12 is using. |
JackBoosY
added
the
category:new-port
JackBoosY
suggested changes
Oct 8, 2022
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for ignition-tools have changed but the version was not updated
version: 1.5.0
old SHA: 591054f6a38ab55686271f8fe1f052b4cd5b4326
new SHA: 0e2a202114e599478fd3e3bebb841a5852f9e48b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
added 2 commits
October 8, 2022 23:33
added 2 commits
October 8, 2022 23:37
JackBoosY
reviewed
Oct 9, 2022
Comment on lines
+23
to
+31
| if (NOT VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug") | ||
| file(GLOB DEBUG_TOOLS "${CURRENT_PACKAGES_DIR}/debug/bin/*") | ||
| file(COPY ${DEBUG_TOOLS} DESTINATION "${CURRENT_PACKAGES_DIR}/debug/tools/${PORT}") | ||
| endif() | ||
|
|
||
| if (NOT VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "release") | ||
| file(GLOB RELEASE_TOOLS "${CURRENT_PACKAGES_DIR}/debug/bin/*") | ||
| file(COPY ${RELEASE_TOOLS} DESTINATION "${CURRENT_PACKAGES_DIR}/tools/${PORT}") | ||
| endif() |
There was a problem hiding this comment.
Note the tools are scripts, not binaries, so we can't use vcpkg_copy_tools.
JackBoosY
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Add ignition-tools for compile sdforamt
What does your PR fix?
Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?
AllDoes your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?YesIf you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/