Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbus] no absolute paths #27036

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

autoantwort
Copy link
Contributor

github-actions[bot]
github-actions bot previously approved these changes Sep 29, 2022
@Neumann-A
Copy link
Contributor

Hmm I think this effectively breaks the tools since those probably require a session.conf from somewhere

@autoantwort
Copy link
Contributor Author

Hm because this file is full of absolute paths and I don't see a way to make them relative

@Neumann-A
Copy link
Contributor

I only see:


  <!-- Include legacy configuration location -->
  <include ignore_missing="yes">E:/xserver-vcpkg/vcpkg/packages/dbus_x64-windows/etc/dbus/dbus-1/session.conf</include>

  <!-- Config files are placed here that among other things, 
       further restrict the above policy for specific services. -->
  <includedir>session.d</includedir>

  <includedir>E:/xserver-vcpkg/vcpkg/packages/dbus_x64-windows/etc/dbus/dbus-1/session.d</includedir>

  <!-- This is included last so local configuration can override what's 
       in this standard file -->
  <include ignore_missing="yes">E:/xserver-vcpkg/vcpkg/packages/dbus_x64-windows/etc/dbus/dbus-1/session-local.conf</include>

  <include if_selinux_enabled="yes" selinux_root_relative="yes">contexts/dbus_contexts</include>

which probably can be replaced by relative dirs considering <includedir>session.d</includedir> or completly removed considering <include ignore_missing="yes">

The other .conf just has the absolute paths in a comment.

@Neumann-A
Copy link
Contributor

But considering: https://dbus.freedesktop.org/doc/dbus-daemon.1.html

I think the conf files need to be moved any way since moving the tools changed the prefix.

@autoantwort
Copy link
Contributor Author

Yeah ok the include things can properly removed. But in system.conf I have

  <!-- This is a setuid helper that is used to launch system services -->
  <servicehelper>/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/packages/dbus_arm64-osx/libexec/dbus-daemon-launch-helper</servicehelper>

  <!-- Write a pid file -->
  <pidfile>/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/packages/dbus_arm64-osx/var/run/dbus/pid</pidfile>

  <!-- Only listen on a local socket. (abstract=/path/to/socket 
       means use abstract namespace, don't really create filesystem 
       file; only Linux supports this. Use path=/whatever on other 
       systems.) -->
  <listen>unix:path=/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/packages/dbus_arm64-osx/var/run/dbus/system_bus_socket</listen>

@Neumann-A
Copy link
Contributor

I think you can delete that file due to: This configuration file controls the systemwide message bus. vcpkg probably doesn't want to mess with that.

@autoantwort
Copy link
Contributor Author

with that.

But the session.conf file is used for the message bus inside a user session. vcpkg probably doesn't want to mess with that either. Maybe vcpkg should not install (build) the daemon at all.

@Neumann-A
Copy link
Contributor

But the session.conf file is used for the message bus inside a user session. vcpkg probably doesn't want to mess with that either. Maybe vcpkg should not install (build) the daemon at all.

windows needs it. Otherwise you don't have a way to test stuff on windows (i think.)

@autoantwort
Copy link
Contributor Author

Ok there is now a session.conf without absolute paths.

@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Sep 30, 2022
@LilyWangLL
Copy link
Contributor

Ok there is now a session.conf without absolute paths.

cc @Neumann-A, could you please review the latest change again? Thanks in advance.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 8, 2022
@vicroms vicroms merged commit 4d85e16 into microsoft:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants