Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][grppi] Manually control use of tbb #26966

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Sep 24, 2022

Describe the pull request

  • What does your PR fix?

    This port has its own FindTBB.cmake and picks up tbb if it is present. I control the use of tbb explicitly by adding it as a feature. I also removed FindTBB.cmake. Note that this port supports other backends as well, but they are not available at vcpkg.

Related error message:

CMake Error at cmake.modules/FindTBB.cmake:187 (file):
  file failed to open for reading (No such file or directory):

    /mnt/vcpkg-ci/installed/x64-linux/include/tbb/tbb_stddef.h
Call Stack (most recent call first):
  /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:829 (_find_package)
  CMakeLists.txt:52 (find_package)

I think we didn't see this before because there is another port that uses a vendored copy of tbb.

@Thomas1664 Thomas1664 changed the title [grppi] Manually control use of tbb [vcpkg baseline][grppi] Manually control use of tbb Sep 24, 2022
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Sep 26, 2022
@JonLiu1993
Copy link
Member

JonLiu1993 commented Sep 26, 2022

Feature tbb is tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JonLiu1993
Copy link
Member

Tesed grppi:x64-windows usage successfully

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 26, 2022
@LilyWangLL
Copy link
Contributor

@dan-shaw Could you please merge this PR? This is a baseline issue.

@dan-shaw dan-shaw merged commit a685b28 into microsoft:master Sep 26, 2022
@Thomas1664 Thomas1664 deleted the grppi branch September 26, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants