[ngtcp2] new port #26955
Merged
[ngtcp2] new port #26955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
talregev
force-pushed
the
TalR/ngtcp2
branch
from
2b39d71 to
2021fb6
Compare
talregev
force-pushed
the
TalR/ngtcp2
branch
from
2021fb6 to
cdae473
Compare
talregev
force-pushed
the
TalR/ngtcp2
branch
from
cdae473 to
e328db0
Compare
Thomas1664
reviewed
Sep 24, 2022
talregev
force-pushed
the
TalR/ngtcp2
branch
from
e328db0 to
091ec02
Compare
|
@Thomas1664 Any more review? |
No, that's all. |
FrankXie05
added
the
category:new-port
|
@talregev The current port does not provide usage, if it is not |
|
Then we need to wait for openssl 3.1. |
FrankXie05
previously approved these changes
Sep 26, 2022
FrankXie05
added
info:reviewed
|
How is usage connected to openssl 3.1? Isn't this port usable at the moment? |
|
Sorry I got the label wrong. |
FrankXie05
added
requires:author-response
and removed
info:reviewed
|
@talregev If we don't add usage, how will we use this port? :) |
dg0yt
suggested changes
Oct 12, 2022
alagoutte
reviewed
Oct 13, 2022
| "description": "ngtcp2 project is an effort to implement RFC9000 QUIC protocol.", | ||
| "homepage": "https://github.com/ngtcp2/ngtcp2", | ||
| "license": "MIT", | ||
| "supports": "!(arm & uwp)", |
There was a problem hiding this comment.
there is a reason to don't support ARM and UWP ?
There was a problem hiding this comment.
PS E:\NEW-PORT\vcpkg> ./vcpkg install ngtcp2:arm64-uwp
Computing installation plan...
The following packages will be built and installed:
ngtcp2[core]:arm64-uwp -> 0.9.0
Detecting compiler hash for triplet arm64-uwp...
Restored 0 package(s) from C:\Users\test\AppData\Local\vcpkg\archives in 670.4 us. Use --debug to see more details.
Installing 1/1 ngtcp2:arm64-uwp...
Building ngtcp2[core]:arm64-uwp...
warning: -- Using community triplet arm64-uwp. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: E:\NEW-PORT\vcpkg\triplets\community\arm64-uwp.cmake
-- Using cached ngtcp2-ngtcp2-v0.9.0.tar.gz.
-- Cleaning sources at E:/NEW-PORT/vcpkg/buildtrees/ngtcp2/src/v0.9.0-3f45192599.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source E:/NEW-PORT/vcpkg/downloads/ngtcp2-ngtcp2-v0.9.0.tar.gz
-- Applying patch export-unofficical-target.patch
-- Using source at E:/NEW-PORT/vcpkg/buildtrees/ngtcp2/src/v0.9.0-3f45192599.clean
-- Found external ninja('1.10.2').
-- Configuring arm64-uwp
-- Building arm64-uwp-dbg
-- Building arm64-uwp-rel
-- Fixing pkgconfig file: E:/NEW-PORT/vcpkg/packages/ngtcp2_arm64-uwp/lib/pkgconfig/libngtcp2.pc
-- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst.
-- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst.
-- Using msys root at E:/NEW-PORT/vcpkg/downloads/tools/msys2/9a1ec3f33446b195
-- Fixing pkgconfig file: E:/NEW-PORT/vcpkg/packages/ngtcp2_arm64-uwp/debug/lib/pkgconfig/libngtcp2.pc
-- Installing: E:/NEW-PORT/vcpkg/packages/ngtcp2_arm64-uwp/share/ngtcp2/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: "C:\Users\test\AppData\Local\vcpkg\archives\f3\f38f92f0d703820d5235f9b77e5a55c75db812ff40f6382bdc38cec9e5c231d8.zip"
Elapsed time to handle ngtcp2:arm64-uwp: 50.21 s
Total elapsed time: 1.178 min
ngtcp2 provides CMake targets:
# this is heuristically generated, and may not be correct
find_package(ngtcp2 CONFIG REQUIRED)
target_link_libraries(main PRIVATE unofficial::ngtcp2::ngtcp2)
PS E:\NEW-PORT\vcpkg>
I can build successfully locally, but arm-uwp is community triplet, we currently cannot guarantee that it can be used normally in subsequent updates.
Adela0814
previously approved these changes
Nov 18, 2022
JavierMatosD
requested changes
Nov 22, 2022
JavierMatosD
added
requires:author-response
and removed
info:reviewed
FrankXie05
dismissed stale reviews from Adela0814 and github-actions[bot]
via
7810a8f
FrankXie05
added
info:reviewed
JavierMatosD
approved these changes
Dec 2, 2022
|
Thank you! |
alagoutte
added a commit
to alagoutte/ngtcp2
that referenced
this pull request
May 13, 2024
it is a patch (https://github.com/microsoft/vcpkg/blob/master/ports/ngtcp2/export-unofficical-target.patch) used by vcpkg package for export cmake configuration (microsoft/vcpkg#26955 (comment)
alagoutte
added a commit
to alagoutte/ngtcp2
that referenced
this pull request
May 13, 2024
it is a patch (https://github.com/microsoft/vcpkg/blob/master/ports/ngtcp2/export-unofficical-target.patch) used by vcpkg package for export cmake configuration (microsoft/vcpkg#26955 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Add new port: ngtcp2 to compile curl with http3.
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/