-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libofx] new port #26864
[libofx] new port #26864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
f79602b
to
388190b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
388190b
to
0817449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
0817449
to
48d2dd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
48d2dd1
to
718d66e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
718d66e
to
2d3cafd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for libofx have changed but the version was not updated
version: 0.10.7
old SHA: f8cf97a9ae490a0539e1465f49b316a73578e1f2
new SHA: 4694e4ca0ea4491bdb9578c160ebe8a0ead63604
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
e98dfc8
to
8a519ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
8a519ba
to
ed62c45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
ed62c45
to
8fa462c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libofx/vcpkg.json
Valid values for the license field can be found in the documentation
@JonLiu1993 ready now for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/libofx/vcpkg.json
(has deprecated licenseGPL-2.0
)
Deprecated and non deprecated license identifiers can be found here
828e01e
to
b94fc6b
Compare
All features are tested successfully in the following triplet:
|
|
@JonLiu1993 just noticed that |
Could you please add it? |
66a6b1f
Done. |
Describe the pull request
Adds a new port for LibOFX. Still a WIP.
Pending:
a LibOFX 0.10.8 release.
Which triplets are supported/not supported? Have you updated the CI baseline?
All official, except UWP on Windows (for now, see Error C2664 when compiling against Microsoft UWP platform libofx/libofx#84) + macOS arm64
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/