[opentelemetry-cpp] Update to 1.6.0 and fix abseil[cxx17]#26857
Merged
vicroms merged 4 commits intomicrosoft:masterfrom Oct 15, 2022
Merged
[opentelemetry-cpp] Update to 1.6.0 and fix abseil[cxx17]#26857vicroms merged 4 commits intomicrosoft:masterfrom
vicroms merged 4 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
added
the
category:port-update
JonLiu1993
previously approved these changes
Sep 19, 2022
Contributor
|
All features are tested successfully in the x64-windows-static triplet. |
JonLiu1993
added
the
info:needs-maintainer-attention
dan-shaw
added
the
requires:vcpkg-team-review
Member
|
Please fix merge conflicts |
vicroms
removed
the
info:needs-maintainer-attention
Tradias
dismissed stale reviews from JonLiu1993 and github-actions[bot]
via
8607048
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for opentelemetry-cpp have changed but the version was not updated
version: 1.6.0
old SHA: 770ac0722ac2df832d39f8fd7e8150d009098c4c
new SHA: b85f6215a2936a5a21c752b11e16fc7250a102b2
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Thomas1664
reviewed
Sep 30, 2022
vicroms
added
requires:author-response
and removed
info:needs-maintainer-attention
vicroms
reviewed
Oct 3, 2022
Contributor
Author
|
Is there anything that blocks this pull request? |
JonLiu1993
added
info:needs-maintainer-attention
Contributor
|
@vicroms, Could you please review again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [opentelemetry-cpp] update to 1.6.0 #26854
Which triplets are supported/not supported? Have you updated the CI baseline?
all, yes
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes