Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configcat] Add new port #26713

Merged
merged 28 commits into from
Sep 13, 2022
Merged

[configcat] Add new port #26713

merged 28 commits into from
Sep 13, 2022

Conversation

kp-cat
Copy link
Contributor

@kp-cat kp-cat commented Sep 7, 2022

Describe the pull request

  • What does your PR?

Add ConfigCat C++ SDK to vcpkg. https://github.com/configcat/cpp-sdk
We would like to use vcpkg as a recommended dependency manager.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot previously approved these changes Sep 7, 2022
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: ab7ca423bcb3d34f89eec564ab2a55ab5f817aea
new SHA: e1083d4f63580710b5402b04a1a53ba7c2fbe448
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/configcat/vcpkg.json b/ports/configcat/vcpkg.json
index b82a7c2..1978384 100644
--- a/ports/configcat/vcpkg.json
+++ b/ports/configcat/vcpkg.json
@@ -8,7 +8,6 @@
     "cpr",
     "hash-library",
     "nlohmann-json",
-    "z4kn4fein-semver",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -16,6 +15,7 @@
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
+    },
+    "z4kn4fein-semver"
   ]
 }
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: e1083d4f63580710b5402b04a1a53ba7c2fbe448
new SHA: d1fc555133fe6f01851027d7f6933ec0e5ce0d3c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: 36fb962ecce5703076cb947df030f8859c10e6f9
new SHA: d1fc555133fe6f01851027d7f6933ec0e5ce0d3c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 8, 2022
@Cheney-W
Copy link
Contributor

Cheney-W commented Sep 9, 2022

Import libs were not present in D:\packages\configcat_x86-windows\debug\lib
If this is intended, add the following line in the portfile:
    SET(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled)
Import libs were not present in D:\packages\configcat_x86-windows\lib
If this is intended, add the following line in the portfile:
    SET(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled)
The following DLLs have no exports:

    D:/packages/configcat_x86-windows/debug/bin/configcat.dll
    D:/packages/configcat_x86-windows/bin/configcat.dll

DLLs without any exports are likely a bug in the build script.
If this is intended, add the following line in the portfile:
    SET(VCPKG_POLICY_DLLS_WITHOUT_EXPORTS enabled)
There should be no empty directories in D:\packages\configcat_x86-windows
The following empty directories were found:

    D:/packages/configcat_x86-windows/debug/lib
    D:/packages/configcat_x86-windows/lib

If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:

    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/lib" "${CURRENT_PACKAGES_DIR}/lib")

Found 4 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile:
    C:\a\1\s\ports\configcat\portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: d1fc555133fe6f01851027d7f6933ec0e5ce0d3c
new SHA: 9cad71839ce2b65e30358060543ecaca658facca
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 9, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: 558db7b7aeaffc304220fbfc654599ca0e999579
new SHA: dd2cf5c872447bbd8ef959ef4bbe088e97c45acc
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 11, 2022
@kp-cat kp-cat requested review from Cheney-W and dg0yt and removed request for dg0yt and Cheney-W September 11, 2022 13:17
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port looks very clean now. 👍

-DCONFIGCAT_BUILD_TESTS=OFF
)
vcpkg_cmake_install()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here between install and cleanup, it lacks

vcpkg_cmake_config_fixup(CONFIG_PATH "share/cmake/configcat")

(from host port vcpkg-cmake-config). It will merge exported release and debug config into share/${PORT}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dg0yt,
I updated the profile.cmake file.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: dd2cf5c872447bbd8ef959ef4bbe088e97c45acc
new SHA: 0e263303b5b97cb7da077ed39e887d1a628346b7
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 11, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: 0e263303b5b97cb7da077ed39e887d1a628346b7
new SHA: 89f6f095be3eafe0791396840655fab33110a321
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 11, 2022
@kp-cat kp-cat requested a review from dg0yt September 11, 2022 15:54
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for configcat have changed but the version was not updated
version: 0.1.0
old SHA: 89f6f095be3eafe0791396840655fab33110a321
new SHA: d163eba9cf1e8cdc7585806666d8f83330c50678
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@kp-cat kp-cat requested review from Cheney-W and dg0yt and removed request for dg0yt and Cheney-W September 12, 2022 13:10
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 13, 2022
@vicroms vicroms merged commit 09007f7 into microsoft:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants