[qt5] Fix the wrong gamepads directory issue.#267
[qt5] Fix the wrong gamepads directory issue.#267alexkaratarakis merged 3 commits intomicrosoft:masterfrom
Conversation
|
Hi @sdcb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
the gamepad plugin had some error or another in our build that caused us to opt not to include it in the initial portfile. As for the plugins directory I'll take a look tomorrow and make sure things are in order. (I think we may have forgotten to delete the directory after moving plugins to /share |
|
@barcharcraz The gamepad dlls and plugins were never removed, they was just moved correctly to the appropriate release/debug directory. The plugins were placed back in the base directory and the debug directory after PR #262. @sdbc This just a variation on the same problem we had with the gamepad dll/lib - debug libraries are recognised by the fact that they end in "d" and the word "gamepad" ends in d (this is the only dll/lib with that issue). The correct solution to this issue is to update the portfile to remove "xinputgamepad.dll" and "xinputgamepad.pdb" from the DEBUG_PLUGINS glob before the debug plugins are moved, or just rename the files back to the release plugins directory after the move. A bit weird that this didn't throw an error when I tested it out on an x64 build, possible that I had some artifacts left behind from a previous build |
|
Looks like it's really a simple issue, I reverted the code and fixed it by changing the xinputgamepad.dll directory, please review. |
|
yup that should work |
|
Thanks for the solid work! : ) |
When I installing the qt5, the following error output was shown:
-- Performing post-build validation
There should be no empty directories in C:/_/3rd/vcpkg/packages/qt5_x86-windows
The following empty directories were found:
If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them)
Found 1 error(s). Please correct the portfile:
C:_\3rd\vcpkg\ports\qt5\portfile.cmake
This PR removed the empty plugins/gamepads folder and everything works now.