Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPP] Bump to version 10.0.18 #26669

Merged
merged 36 commits into from
Sep 13, 2022
Merged

[DPP] Bump to version 10.0.18 #26669

merged 36 commits into from
Sep 13, 2022

Conversation

braindigitalis
Copy link
Contributor

This PR updates DPP package to 10.0.18

Our vcpkg update is built from our CI actions.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Triplets are unchanged, baseline not updated.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@braindigitalis braindigitalis marked this pull request as ready for review September 3, 2022 20:30
@Adela0814 Adela0814 self-assigned this Sep 5, 2022
Adela0814
Adela0814 previously approved these changes Sep 5, 2022
@Adela0814 Adela0814 added category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines labels Sep 5, 2022
@dan-shaw
Copy link
Contributor

dan-shaw commented Sep 7, 2022

Can you fix the merge conflicts?

@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for dpp have changed but the version was not updated
version: 10.0.18
old SHA: d3b9a27035fbf133d20d21f41e1db5bb1442ed8f
new SHA: 7e80b88acd9bc75ce2b9bcaeae729f758ca2fcde
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@braindigitalis
Copy link
Contributor Author

uh how do i fix this??? you asked me to resolve the merge conflicts (there werent any when i submitted this pr) and now i get this from the bot?

@Adela0814
Copy link
Contributor

Please git pull the latest master branch and fix the conflicts.

    Error: While reading versions for port dpp from file: C:\a\1\s\versions\d-\dpp.json
       File declares version `10.0.18` with SHA: d3b9a27035fbf133d20d21f41e1db5bb1442ed8f
       But local port with the same version has a different SHA: 7e80b88acd9bc75ce2b9bcaeae729f758ca2fcde

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for dpp have changed but the version was not updated
version: 10.0.18
old SHA: d3b9a27035fbf133d20d21f41e1db5bb1442ed8f
new SHA: 7e80b88acd9bc75ce2b9bcaeae729f758ca2fcde
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@braindigitalis
Copy link
Contributor Author

thanks, pr is updated

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 13, 2022
@vicroms vicroms merged commit 34f072d into microsoft:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants