Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_acquire_msys] add 'which' package to default set on Windows #26618

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Aug 31, 2022

Describe the pull request
This adds a which package to vcpkg_acquire_msys and adds it to the list of default packages acquired on Windows in vcpkg_configure_make. which is commonly used by autotools macros, see e.g. https://cs.github.com/?scopeName=All+repos&scope=&q=path%3A*.m4+%60which

By not providing it, many macros will fail their checks with which: command not found, which actually implies the which command itself is missing, not the command which which is supposed to locate.

@Osyotr
Copy link
Contributor

Osyotr commented Aug 31, 2022

Maybe also add autoconf-archive?

@wrobelda
Copy link
Contributor Author

wrobelda commented Aug 31, 2022

Maybe also add autoconf-archive?

It's already in vcpkg_acquire_msys. Adding it to vcpkg_configure_make was discussed recently and found unnecessary for almost all ports, which, in turn, it would slow down. Which I concur with.

EDIT: discussed here: #24870

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Sep 1, 2022
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

Waiting for merge #26646 first.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 6, 2022
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 15, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 16, 2022
@dan-shaw dan-shaw merged commit 4340582 into microsoft:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants