-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg scripts] Crosscompiling fixes #26617
Merged
Merged
Changes from 17 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
cff0492
test osx stuff
Neumann-A 3f0bf20
deactivate most of ci
Neumann-A ce3fd60
get trace output
Neumann-A 43553d9
add required flags to the linker flags
Neumann-A b8f6974
also look for --sysroot
Neumann-A c411a33
Link_args are always shared
Neumann-A 5578e67
fix ar flags
Neumann-A ac5c8f9
setup FOR_BUILD vars.
Neumann-A 98e8b82
try tricking the build.... but man configure scripts are stupid somet…
Neumann-A 4b5f803
try 2
Neumann-A cf7adeb
major meson rewrite
Neumann-A d905202
fix duplicates
Neumann-A 8c6339f
revert --trace-expand
Neumann-A 6757d04
update port version
Neumann-A 0bc3956
Merge remote-tracking branch 'upstream/master' into fix_cpp_osx_and_o…
Neumann-A 332329f
revert pipeline changes
Neumann-A 8b311a4
v db
Neumann-A 886beb6
bump version
Neumann-A 8ee8423
v db
Neumann-A 002f6ba
set flags for rc compilers
Neumann-A a5b9bc8
a few more ios fixes.
Neumann-A 133b0a0
v db
Neumann-A 176edfb
fix osx/ios logic
Neumann-A 22564ed
documentation and don't fatal_error in build/host machine entry calcu…
Neumann-A b4a45aa
Merge branch 'fix_cpp_osx_and_others' of https://github.com/Neumann-A…
Neumann-A 1570c35
add android/compiler target stuff from #26570
Neumann-A 1673027
remove extra endif
Neumann-A d347f83
Merge branch 'master' of https://github.com/microsoft/vcpkg into fix_…
357b504
Merge remote-tracking branch 'upstream/master' into fix_cpp_osx_and_o…
Neumann-A 5b30569
v db
Neumann-A 7e4ffa9
add target param to linker flags.
Neumann-A 4acc2d0
target in cpp flags
Neumann-A 005ccbe
Make vcpkg-cmake-get-vars more ios compatible
m-kuhn ad5ae3b
Merge pull request #10 from opengisch/opengisch/misc-osx-ios-android
Neumann-A 6aca335
Update scripts/get_cmake_vars/CMakeLists.txt
Neumann-A ceb7bfe
More ios fixes
m-kuhn af8f8ea
Merge pull request #11 from m-kuhn/moreios
Neumann-A 6f18956
fix target adding
Neumann-A 4b8384e
Merge branch 'fix_cpp_osx_and_others' of https://github.com/Neumann-A…
Neumann-A 21553e5
Fix broken loop
m-kuhn c144ba1
Merge pull request #12 from m-kuhn/fix_broken_loop
Neumann-A d902437
v db
Neumann-A 342d37f
Merge branch 'fix_cpp_osx_and_others' of https://github.com/Neumann-A…
Neumann-A 0475e5d
v db
Neumann-A a333006
Merge remote-tracking branch 'upstream/master' into fix_cpp_osx_and_o…
Neumann-A 051c678
bump date
Neumann-A e422921
v db
Neumann-A 96b5807
v db
Neumann-A 184abe3
Merge branch 'microsoft:master' into fix_cpp_osx_and_others
Neumann-A f27f316
Merge branch 'microsoft:master' into fix_cpp_osx_and_others
Neumann-A 999c02e
Merge branch 'microsoft:master' into fix_cpp_osx_and_others
Neumann-A 0bf1edb
Merge remote-tracking branch 'upstream/master' into fix_cpp_osx_and_o…
Neumann-A 7292d87
v db
Neumann-A 6ae069e
remove port-version 1
Neumann-A 29d5b6d
v db
Neumann-A File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "vcpkg-cmake", | ||
"version-date": "2022-07-18", | ||
"version-date": "2022-09-04", | ||
"documentation": "https://vcpkg.io/en/docs/maintainers/ports/vcpkg-cmake.html", | ||
"license": "MIT" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
[binaries] | ||
cmake = ['@CMAKE_COMMAND@'] | ||
python = ['@PYTHON3@'] | ||
ninja = ['@NINJA@'] | ||
pkgconfig= ['@PKGCONFIG@'] | ||
@MESON_MT@ | ||
@MESON_AR@ | ||
@MESON_C@ | ||
@MESON_C_LD@ | ||
@MESON_CXX@ | ||
@MESON_CXX_LD@ | ||
@MESON_OBJC@ | ||
@MESON_OBJC_LD@ | ||
@MESON_OBJCPP@ | ||
@MESON_OBJCPP_LD@ | ||
@MESON_FC@ | ||
@MESON_FC_LD@ | ||
@MESON_WINDRES@ | ||
@MESON_ADDITIONAL_BINARIES@ | ||
[properties] | ||
cmake_toolchain_file = '@SCRIPTS@/buildsystems/vcpkg.cmake' | ||
[cmake] | ||
VCPKG_TARGET_TRIPLET = '@TARGET_TRIPLET@' | ||
VCPKG_HOST_TRIPLET = '@_HOST_TRIPLET@' | ||
VCPKG_CHAINLOAD_TOOLCHAIN_FILE = '@VCPKG_CHAINLOAD_TOOLCHAIN_FILE@' | ||
VCPKG_CRT_LINKAGE = '@VCPKG_CRT_LINKAGE@' | ||
_VCPKG_INSTALLED_DIR = '@_VCPKG_INSTALLED_DIR@' | ||
@MESON_HOST_MACHINE@ | ||
@MESON_BUILD_MACHINE@ | ||
[built-in options] | ||
default_library = '@MESON_DEFAULT_LIBRARY@' | ||
werror = false | ||
@MESON_CFLAGS@ | ||
@MESON_CXXFLAGS@ | ||
@MESON_FCFLAGS@ | ||
@MESON_OBJCFLAGS@ | ||
@MESON_OBJCPPFLAGS@ | ||
# b_vscrt | ||
@MESON_VSCRT_LINKAGE@ | ||
# c_winlibs/cpp_winlibs | ||
@MESON_WINLIBS@ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn doesn't this also need
--target(=| )
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally had it on ldflags also but it ran fine without in the recent tests. I cannot think of a reason for this to be present in cppflags but ultimately i only believe successful builds when it comes to autoconf based builds.
Let me test again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpp configure results might depend on it? I assume the correct regex is
...|--target=|-target|...
(similar to sysroot) if I remember the platform stuff in cmake correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got around to testing your branch, you are correct.
Also
LDFLAGS
will need it otherwiselibpq
forarm-neon-android
fails with