Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orc] update to 1.7.6 #26603

Merged
merged 4 commits into from
Aug 31, 2022
Merged

[orc] update to 1.7.6 #26603

merged 4 commits into from
Aug 31, 2022

Conversation

JonLiu1993
Copy link
Member

Fix #23118

Update orc to the latest 1.7.6

Note: no feature need to test

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Aug 31, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 31, 2022

if (1)
- find_package (ZSTD CONFIG REQUIRED)
+ find_package (zstd CONFIG REQUIRED)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix error:

CMake Error at /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:829 (_find_package):
  Could not find a package configuration file provided by "ZSTD" with any of
  the following names:

    ZSTDConfig.cmake
    zstd-config.cmake


if (1)
find_package (Protobuf CONFIG REQUIRED)
+ include_directories(${Protobuf_INCLUDE_DIRS})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix error:

/Users/vagrant/Data/buildtrees/orc/x64-osx-dbg/c++/src/orc_proto.pb.h:10:10: fatal error: 'google/protobuf/port_def.inc' file not found
#include <google/protobuf/port_def.inc>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@JonLiu1993 JonLiu1993 marked this pull request as ready for review August 31, 2022 06:47
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Aug 31, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 8510361 into microsoft:master Aug 31, 2022
@JonLiu1993 JonLiu1993 deleted the dev/Jon/orc branch September 1, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[orc] update to 1.7.2 or higher
3 participants