-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg baseline][gstreamer] Fix interference with libx11 on Windows #26574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e85b5bb95a14ff7e014601e88a8dc2fea6798e33 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 85d6b83..dbb23b3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2738,7 +2738,7 @@
},
"gstreamer": {
"baseline": "1.19.2",
- "port-version": 6
+ "port-version": 7
},
"gtest": {
"baseline": "1.12.1",
diff --git a/versions/g-/gstreamer.json b/versions/g-/gstreamer.json
index f475f0a..75c5cb3 100644
--- a/versions/g-/gstreamer.json
+++ b/versions/g-/gstreamer.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "0b02acdb7e1404739f8dcf3b1ad16c0847d4b1a1",
+ "version": "1.19.2",
+ "port-version": 7
+ },
{
"git-tree": "245207bd8010181848ffaad5822f2492f2cb2b38",
"version": "1.19.2",
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/gstreamer/vcpkg.json
(has deprecated licenseGPL-2.0
)
Deprecated and non deprecated license identifiers can be found here
Don't forget run |
Any process? We need to fix this quickly. |
I can add this feature but I'm against manual configure to use x11 as we might interfere with the |
No. Add a meson option and deactivate it for windows for now. Dont add a depenency on libx11 on windows. (Other platforms might need it however) |
@JackBoosY Please also note that our port will be empty on OSX |
Would this replace/ overwrite the default OSX window system?
I'm not adding a dependency on x11 on Windows. |
Thanks! |
Describe the pull request
What does your PR fix?
gstreamer
interferes withlibx11
on Windows.Evidence: [invalid][gstreamer] Prove that x11 causes build failure #26575