Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xwindow] part 3/n #26572

Merged
merged 6 commits into from
Aug 31, 2022
Merged

[xwindow] part 3/n #26572

merged 6 commits into from
Aug 31, 2022

Conversation

Neumann-A
Copy link
Contributor

adds

  • xcb-render-util
  • libxkbfile
  • libxkbcommon

github-actions[bot]
github-actions bot previously approved these changes Aug 28, 2022
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 29, 2022
LilyWangLL
LilyWangLL previously approved these changes Aug 29, 2022
@LilyWangLL
Copy link
Contributor

These 3 ports test pass on Linux when set X_VCPKG_FORCE_VCPKG_X_LIBRARIES in x64-linux.cmake.

ryihan
ryihan previously approved these changes Aug 29, 2022
@Neumann-A Neumann-A dismissed stale reviews from ryihan and LilyWangLL via 901f940 August 29, 2022 19:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libxkbcommon have changed but the version was not updated
version: 1.4.1
old SHA: e3eb9c316d6a1d6c7b980607da71d273f162cf1e
new SHA: 41ae34eb1eb104faea75a726f115e0e774c17d65
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for libxkbfile have changed but the version was not updated
version: 1.1.0
old SHA: 5c319de6ec7fc61e0a84f5d81aaf188cc2f84bdb
new SHA: 4b6df8dfd8284d03ff745d341c1269c191027811
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 30, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 6eb35f5 into microsoft:master Aug 31, 2022
@Neumann-A Neumann-A deleted the xwindows_part_3 branch September 1, 2022 03:04
@vicroms vicroms mentioned this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants