-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imath] Avoid conflicts between openexr and imath #26513
Conversation
Openexr-2 already includes imath, so we cannot mix them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for opencolorio have changed but the version was not updated
version: 2.1.2
old SHA: d728bb2681e89ffbe9c6e1ec2811d5d194d9fd09
new SHA: 87a5292148dd3f18a44a6c7bdbc7ba45d52c3d8f
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for alembic have changed but the version was not updated
version: 1.8.3#1
old SHA: 16bef528ef38e7426a333739878188d9ca909bc5
new SHA: 955d7dbf5f765fb910fbcc92b2f47f588d4517a3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/alembic/vcpkg.json
Valid values for the license field can be found in the documentation
I think this PR is invalid. (The problem is valid, but the solution will be different.)
Actually port You can install both ports at the same time, but you can't use them at the same time. vcpkg/ports/openimageio/imath-version-guard.patch Lines 9 to 13 in 55112eb
The ultimate solution is to update |
Hi, please accelerate this if possible; is breaking OpenColorIO |
|
||
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||
|
||
file(INSTALL "${SOURCE_PATH}/LICENSE.md" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't just remove this port, add set(VCPKG_POLICY_EMPTY_PACKAGE enabled)
here, and add openexr
to imath
's dependency in vcpkg.json.
You can refer the change of PR #26655.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is invalid anyways. Imath is separate from openexr 3.
This whole PR is obsolete with #26862.
Ping @fabiencastan for response. |
Ping @fabiencastan for response. Is work still being done for this PR? |
I hope not. Cf. #26513 (comment). |
No, everything is working fine with the great work to move to openexr-3! |
Describe the pull request
Imath is included in openexr and the install of imath or openexr will overide the other one.
So, currently the system is broken and we cannot install both openexr and alembic, as it will end up in 2 differents versions mixed up.
What does your PR fix?
Use openexr which contains the latest version of imath.
Which triplets are supported/not supported? Have you updated the [CI baseline]
Does not change anything.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Not yet, I would like to get feedback.