Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google-cloud-cpp] Fix features dialogflow-* CMake export #26480

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

LilyWangLL
Copy link
Contributor

Describe the pull request

Another thing I noticed is that, after the previous change is done and once the process finished compiling, some files and folders were missing in the "packages" folder

In the file "install-x64-windows-rel-out.log" I see (among other lines)

-- Installing: C:/files/repos/other-external/vcpkg/packages/google-cloud-cpp_x64-windows/lib/pkgconfig/google_cloud_cpp_dialogflow_es.pc
-- Installing: C:/files/repos/other-external/vcpkg/packages/google-cloud-cpp_x64-windows/lib/cmake/google_cloud_cpp_dialogflow_es/google_cloud_cpp_dialogflow_es-config.cmake
-- Installing: C:/files/repos/other-external/vcpkg/packages/google-cloud-cpp_x64-windows/lib/cmake/google_cloud_cpp_dialogflow_es/google_cloud_cpp_dialogflow_es-config-version.cmake
-- Installing: C:/files/repos/other-external/vcpkg/packages/google-cloud-cpp_x64-windows/lib/pkgconfig/google_cloud_cpp_dialogflow_es_protos.pc

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 23, 2022
@LilyWangLL LilyWangLL marked this pull request as ready for review August 23, 2022 03:01
@LilyWangLL LilyWangLL requested a review from JackBoosY August 23, 2022 03:02
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 23, 2022
@JavierMatosD
Copy link
Contributor

Thank you @LilyWangLL :)

@JavierMatosD JavierMatosD merged commit d044f52 into microsoft:master Aug 23, 2022
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue26442_1 branch December 19, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[google-cloud-cpp] Problem compiling dialogflow-es package
3 participants