Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update README_zh_CN.md #26456

Merged
merged 1 commit into from
Aug 22, 2022
Merged

[DOCS] Update README_zh_CN.md #26456

merged 1 commit into from
Aug 22, 2022

Conversation

ChungZH
Copy link
Contributor

@ChungZH ChungZH commented Aug 22, 2022

Describe the pull request

  • What does your PR fix?

    cmake -> CMake

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

    Your answer

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    <Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@Cheney-W Cheney-W added category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines labels Aug 22, 2022
@Cheney-W Cheney-W changed the title Update README_zh_CN.md [DOCS] Update README_zh_CN.md Aug 22, 2022
@@ -5,9 +5,9 @@
Vcpkg 可帮助您在 Windows、 Linux 和 MacOS 上管理 C 和 C++ 库。
这个工具和生态链正在不断发展,我们一直期待您的贡献!

若您从未使用过vcpkg,或者您正在尝试了解如何使用vcpkg,请查阅 [入门](#入门) 章节。
若您从未使用过 vcpkg,或者您正在尝试了解如何使用 vcpkg,请查阅 [入门](#入门) 章节。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding space is needed. @JackBoosY

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding space is needed. @JackBoosY

https://github.com/sparanoid/chinese-copywriting-guidelines

Adding spaces makes it prettier and easier to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I agree with this change for this reason. Thanks @ChungZH's work~

@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Aug 22, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 22, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit f4df5da into microsoft:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants