Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated VCPKG_PREFER_SYSTEM_LIBS #26449

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Aug 21, 2022

Factored out of #21783.

  • What does your PR fix?

    Deprecates VCPKG_PREFER_SYSTEM_LIBS, suggesting overlay ports as a reliable alternative.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    not needed

@dg0yt dg0yt changed the title [world rebuild] Deprecated VCPKG_PREFER_SYSTEM_LIBS Deprecated VCPKG_PREFER_SYSTEM_LIBS Aug 21, 2022
@dg0yt
Copy link
Contributor Author

dg0yt commented Aug 21, 2022

No world rebuild (and it is not needed anyways).

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Aug 22, 2022
@JackBoosY
Copy link
Contributor

cc @Neumann-A

@JackBoosY
Copy link
Contributor

@dg0yt dg0yt marked this pull request as ready for review August 22, 2022 06:28
@@ -213,6 +213,8 @@ This variable can be set to a list of additional command line parameters to pass

### `VCPKG_PREFER_SYSTEM_LIBS`

**This feature has been deprecated. Use empty overlay ports instead.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add a link to the overlay documentation here.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 23, 2022
@JavierMatosD JavierMatosD merged commit 02fcf92 into microsoft:master Aug 23, 2022
@dg0yt dg0yt deleted the deprecate-prefer-system-libs branch August 24, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants