-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ceres] Use ceres without gflags for [arm-uwp] build #26434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for ceres have changed but the version was not updated
version: 2.1.0#1
old SHA: 85a5ff9f8727124ce91655f2d37b9a6c77f367e1
new SHA: 7b80d8b91cc99d3200338efaa46cd9638ea64e5c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
@FrankXie05 Hi, I hope you are doing well. I wonder why Azure Pipelines fails to build on those releases. Is there any suggestion in this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for ceres have changed but the version was not updated
version: 2.1.0#2
old SHA: 7b80d8b91cc99d3200338efaa46cd9638ea64e5c
new SHA: ec9ae0b91949b1edfbb3d9dcadc597ddafd20b8d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Error for CI:
The error message comes from the log:
install-x86-windows-dbg-out (2).log The reason for the error: CI will test all the dependent ports related to vcpkg/ports/openmvg/vcpkg.json Line 10 in 8563627
cartographer , and they rely on the glog provided by the port ceres .
You can get detailed logs here. https://dev.azure.com/vcpkg/public/_build/results?buildId=76918&view=artifacts&pathAsName=false&type=publishedArtifacts I hope it can help you. :) |
I understand. I deleted glog, since is not possible to use glog in UWP. How can I mantain glog in all !UWP platforms and just disable it in UWP Platforms ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for ceres have changed but the version was not updated
version: 2.1.0#2
old SHA: 5ec2328f417cf8a3f164cc1261d61234e0b58eff
new SHA: 43ad6a8a731304eba4446bb6c0a62eb64873a682
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the target is uwp is activates miniglog to build ceres un uwp-arm
@FrankXie05 Hi Frank, I closed the PR by accident, is it possible to reopen it again for review and merge ? |
@adolfos94 It doesn't matter, we are very happy to improve |
foreach (FEATURE ${FEATURE_OPTIONS}) | ||
message(STATUS "${FEATURE}") | ||
endforeach() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foreach (FEATURE ${FEATURE_OPTIONS}) | |
message(STATUS "${FEATURE}") | |
endforeach() |
I think it's a bit redundant. Redundant information is not good for observing the port build process.
Although I know it's here to observe the states of the features under different triplets (especially the MINIGLOG
). 🤔
I will approve it for team review.
Thank you! |
It disables glog by default in order to build ceres with miniglog in arm-uwp.
What does your PR fix?
It disabled glog in uwp-arm by default, since is not possible to build gflags in uwp-arm.
Which triplets are supported/not supported? Have you updated the CI baseline?
All
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/