Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ceres] Use ceres without gflags for [arm-uwp] build #26434

Merged
merged 11 commits into from
Aug 24, 2022

Conversation

adolfos94
Copy link
Contributor

@adolfos94 adolfos94 commented Aug 20, 2022

It disables glog by default in order to build ceres with miniglog in arm-uwp.

  • What does your PR fix?

It disabled glog in uwp-arm by default, since is not possible to build gflags in uwp-arm.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Aug 20, 2022

CLA assistant check
All CLA requirements met.

@adolfos94 adolfos94 changed the title Use ceres without gflags for UWP-ARM64 build [ceres] Use ceres without gflags for [arm64-uwp] build Aug 20, 2022
@FrankXie05 FrankXie05 self-assigned this Aug 22, 2022
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 22, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for ceres have changed but the version was not updated
version: 2.1.0#1
old SHA: 85a5ff9f8727124ce91655f2d37b9a6c77f367e1
new SHA: 7b80d8b91cc99d3200338efaa46cd9638ea64e5c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@adolfos94 adolfos94 marked this pull request as ready for review August 23, 2022 01:34
@adolfos94
Copy link
Contributor Author

adolfos94 commented Aug 23, 2022

@FrankXie05 Hi, I hope you are doing well.

I wonder why Azure Pipelines fails to build on those releases. Is there any suggestion in this PR ?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for ceres have changed but the version was not updated
version: 2.1.0#2
old SHA: 7b80d8b91cc99d3200338efaa46cd9638ea64e5c
new SHA: ec9ae0b91949b1edfbb3d9dcadc597ddafd20b8d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@FrankXie05
Copy link
Contributor

Error for CI:

  1. verison : run command ./vcpkg x-add-version ceres --overwrite-version after your changes
  2. For errors:

The error message comes from the log:

Openvg: install-x86-windows-dbg-out .log(3)
install-x86-windows-dbg-out (3).log

D:\installed\x86-windows\include\glog/log_severity.h(57): fatal error C1189: #error: ERROR macro is defined. Define GLOG_NO_ABBREVIATED_SEVERITIES before including logging.h. See the document for detail.

cartographer: install-x86-windows-dbg-out (2).log:

D:\installed\x86-windows\include\glog/log_severity.h(57): fatal error C1189: #error:  ERROR macro is defined. Define GLOG_NO_ABBREVIATED_SEVERITIES before including logging.h. See the document for detail.

install-x86-windows-dbg-out (2).log

The reason for the error: CI will test all the dependent ports related to ceres. These include openmvg

"name": "ceres",
and cartographer , and they rely on the glog provided by the port ceres.

  1. Why delete glog?
  2. For arm64-uwp triplet, it belongs to VCPKG community triplets, we cannot guarantee that it can be used normally.

You can get detailed logs here. https://dev.azure.com/vcpkg/public/_build/results?buildId=76918&view=artifacts&pathAsName=false&type=publishedArtifacts I hope it can help you. :)

ports/ceres/vcpkg.json Show resolved Hide resolved
@adolfos94
Copy link
Contributor Author

Error for CI:

  1. verison : run command ./vcpkg x-add-version ceres --overwrite-version after your changes
  2. For errors:

The error message comes from the log:

Openvg: install-x86-windows-dbg-out .log(3) install-x86-windows-dbg-out (3).log

D:\installed\x86-windows\include\glog/log_severity.h(57): fatal error C1189: #error: ERROR macro is defined. Define GLOG_NO_ABBREVIATED_SEVERITIES before including logging.h. See the document for detail.

cartographer: install-x86-windows-dbg-out (2).log:

D:\installed\x86-windows\include\glog/log_severity.h(57): fatal error C1189: #error:  ERROR macro is defined. Define GLOG_NO_ABBREVIATED_SEVERITIES before including logging.h. See the document for detail.

install-x86-windows-dbg-out (2).log

The reason for the error: CI will test all the dependent ports related to ceres. These include openmvg

"name": "ceres",

and cartographer , and they rely on the glog provided by the port ceres.
3. Why delete glog?
4. For arm64-uwp triplet, it belongs to VCPKG community triplets, we cannot guarantee that it can be used normally.

You can get detailed logs here. https://dev.azure.com/vcpkg/public/_build/results?buildId=76918&view=artifacts&pathAsName=false&type=publishedArtifacts I hope it can help you. :)

I understand. I deleted glog, since is not possible to use glog in UWP. How can I mantain glog in all !UWP platforms and just disable it in UWP Platforms ?

@adolfos94 adolfos94 changed the title [ceres] Use ceres without gflags for [arm64-uwp] build [ceres] Use ceres without gflags for [arm-uwp] build Aug 23, 2022
@adolfos94 adolfos94 marked this pull request as draft August 23, 2022 03:36
ports/ceres/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for ceres have changed but the version was not updated
version: 2.1.0#2
old SHA: 5ec2328f417cf8a3f164cc1261d61234e0b58eff
new SHA: 43ad6a8a731304eba4446bb6c0a62eb64873a682
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@adolfos94 adolfos94 marked this pull request as ready for review August 24, 2022 00:52
Copy link
Contributor Author

@adolfos94 adolfos94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the target is uwp is activates miniglog to build ceres un uwp-arm

@adolfos94 adolfos94 requested review from FrankXie05 and removed request for github-actions[bot] August 24, 2022 00:55
@adolfos94 adolfos94 closed this Aug 24, 2022
@adolfos94
Copy link
Contributor Author

@FrankXie05 Hi Frank,

I closed the PR by accident, is it possible to reopen it again for review and merge ?

@adolfos94 adolfos94 reopened this Aug 24, 2022
@FrankXie05
Copy link
Contributor

@adolfos94 It doesn't matter, we are very happy to improve vcpkg for the PRs submitted by everyone. :)

Comment on lines +42 to +44
foreach (FEATURE ${FEATURE_OPTIONS})
message(STATUS "${FEATURE}")
endforeach()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
foreach (FEATURE ${FEATURE_OPTIONS})
message(STATUS "${FEATURE}")
endforeach()

I think it's a bit redundant. Redundant information is not good for observing the port build process.
Although I know it's here to observe the states of the features under different triplets (especially the MINIGLOG). 🤔
I will approve it for team review.

@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 24, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 9eb1977 into microsoft:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants