Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Update the version to 2.0.2 #26411

Merged
merged 52 commits into from
Aug 26, 2022
Merged

Conversation

daniele77
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Update cli library

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

daniele77 and others added 30 commits September 17, 2019 10:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4217fee510d4c592d3e45564d3ee116ae301189f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index cde93109..82748cf1 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1433,7 +1433,7 @@
       "port-version": 5
     },
     "cli": {
-      "baseline": "2.0.1",
+      "baseline": "2.0.2",
       "port-version": 0
     },
     "cli11": {
diff --git a/versions/c-/cli.json b/versions/c-/cli.json
index 1c705d9b..3e0b9f99 100644
--- a/versions/c-/cli.json
+++ b/versions/c-/cli.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "72fd89f268dc5d3318561366f54ee6aed341669f",
+      "version": "2.0.2",
+      "port-version": 0
+    },
     {
       "git-tree": "25a075116903bfd73e5a1e4f63638955c1a52732",
       "version": "2.0.1",

@FrankXie05 FrankXie05 self-assigned this Aug 19, 2022
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 19, 2022
@FrankXie05
Copy link
Contributor

@daniele77 Please bump the port version. See documentation.
Also please run command vcpkg x-add-version --all then commit the changes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for cli have changed but the version was not updated
version: 2.0.2#1
old SHA: 72fd89f268dc5d3318561366f54ee6aed341669f
new SHA: 9b1df5161c1fec8a3fcab4fb6b3f3bae73bd0732
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@daniele77
Copy link
Contributor Author

@daniele77 Please bump the port version. See documentation. Also please run command vcpkg x-add-version --all then commit the changes.

Done.

But please notice that the command vcpkg x-add-version --all gives errors on the current repository because of errors in other libraries' ports). E.g.;

Error: Unable to parse versions file /home/daniele/projects/sideprojects/github/vcpkg/versions/m-/muparser.json.
Error: failed to parse versions file for `muparser`:
$.versions[2] (a version database entry): 'version' text was not a relaxed version:
Error: String `2.3.3-1` must only contain dot-separated numeric values without leading zeroes.

So, instead of vcpkg x-add-version --all I used vcpkg x-add-version cli.

@FrankXie05
Copy link
Contributor

@daniele77 The command -all will check all your local port version fields.
According to your error, it shows that the version field of your local port muparser is obviously not in compliance with the specification.
Of course, it doesn't matter if the content of the locally modified file is not committed. :)

ports/cli/vcpkg.json Outdated Show resolved Hide resolved
versions/baseline.json Outdated Show resolved Hide resolved
@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 26, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit e049c9c into microsoft:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants