Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libswscale aarch64 fix #26404

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Conversation

samsinsane
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes an issue with FFMPEG for aarch64 where the gas-preprocessor.pl script won't match the conditionals that have comments at the end. This results in none of the conditions matching, none of the compute_rgba macro calls being injected, and intermediate data being output at runtime instead.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    arm64-uwp (maybe all arm64, I was only working with UWP), No

  • Does your PR follow the maintainer guide?

    From my understanding, yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@ghost
Copy link

ghost commented Aug 18, 2022

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Aug 19, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 19, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 2ca44de into microsoft:master Aug 19, 2022
@samsinsane samsinsane deleted the libswscaleAarch64Fix branch August 22, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants