Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opus/x265] Fix version in pkgconfig #26389

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 17, 2022

Version control file (such as .git) is used in the source to extract the version number, but this is not available in the direct download package.
Add a fixed patch and pass in the version number to avoid extra changes to the source files.

Fixes #26369.
Fixes #25680.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 17, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for opus have changed but the version was not updated
version: 1.3.1#7
old SHA: 8db6dcfda566f3822159cde54020c73a8c170c7a
new SHA: ad2b9149564516603dab6b996af3d4bc7ba29017
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/x265/vcpkg.json (has deprecated license GPL-2.0)

Deprecated and non deprecated license identifiers can be found here

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for opus have changed but the version was not updated
version: 1.3.1#7
old SHA: 8db6dcfda566f3822159cde54020c73a8c170c7a
new SHA: ad2b9149564516603dab6b996af3d4bc7ba29017
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@Sharpe49
Copy link
Contributor

Also fixes #25680

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 18, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 571a055 into microsoft:master Aug 18, 2022
@JackBoosY JackBoosY deleted the dev/jack/26369 branch August 19, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
4 participants