Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] add updated compile wrapper for clang-cl #26340

Merged
merged 6 commits into from
Aug 30, 2022

Conversation

Neumann-A
Copy link
Contributor

has already been merged upstream but I have no clue when it will be in automake from msys.
The relevant change is line 259.

Alternatively we could just patch the msys download? But where should those patches be stored?

github-actions[bot]
github-actions bot previously approved these changes Aug 13, 2022
@Cheney-W Cheney-W self-assigned this Aug 15, 2022
@Cheney-W Cheney-W changed the title add updated compile wrapper for clang-cl [vcpkg] add updated compile wrapper for clang-cl Aug 15, 2022
@Cheney-W Cheney-W added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines labels Aug 15, 2022
@JavierMatosD
Copy link
Contributor

has already been merged upstream but I have no clue when it will be in automake from msys. The relevant change is line 259.

Alternatively we could just patch the msys download? But where should those patches be stored?

I am concerned about the potential licensing implications of this. Is it unreasonable to wait for msys?

@JavierMatosD JavierMatosD added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 15, 2022
@Neumann-A
Copy link
Contributor Author

I am concerned about the potential licensing implications of this. Is it unreasonable to wait for msys?

I feared that that would be the answer. So where should I store the patch for msys ? ;)

@ras0219-msft
Copy link
Contributor

scripts/msys/xyz.patch; vcpkg_acquire_msys() then can apply the patch after un-tarring all the packages together but before renaming if it detects that the automake package was requested.

github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2022
@Neumann-A
Copy link
Contributor Author

@ras0219-msft: Done.

@JavierMatosD
Copy link
Contributor

Thanks!

@JavierMatosD JavierMatosD merged commit f688b2e into microsoft:master Aug 30, 2022
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Aug 30, 2022
[vcpkg] add updated compile wrapper for clang-cl (microsoft#26340)
@Neumann-A Neumann-A deleted the clang-cl_compile_wrapper branch August 31, 2022 17:35
@Neumann-A
Copy link
Contributor Author

@dg0yt Couldn't you also patch libtool with this? Or am I pinging the wrong person.

@dg0yt
Copy link
Contributor

dg0yt commented Sep 4, 2022

@Neumann-A libtool is considered external and not accepted as a port.

@Neumann-A
Copy link
Contributor Author

@Neumann-A libtool is considered external and not accepted as a port.

didn't you have changes to bash scripts which could now be patched into vcpkg_acquire_msys ?

@dg0yt
Copy link
Contributor

dg0yt commented Sep 4, 2022

@Neumann-A Sorry, the PR title was unable to convey the information that this PR contains relevant changes, such as a PATCHES option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants