Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[szip] add definitions for the try_run call for iOS #26329

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

russelltg
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes building szip for iOS

  • Which triplets are supported/not supported? Have you updated the CI baseline?

arm64-ios and arm-ios were tested, and they build. I currently have no way to confirm functionality, but I have checked that my additions should be correct in theory.

It seems like it. My comments may be too verbose, but I think they're helpful to know why the cached output is correct and acceptable.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@ghost
Copy link

ghost commented Aug 13, 2022

CLA assistant check
All CLA requirements met.

@Cheney-W Cheney-W added category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Aug 15, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants