Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VCPKG_TARGET_IS_EMSCRIPTEN, fix opus and libsodium ports for wasm32-emscripten #26318

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

past-due
Copy link
Contributor

Describe the pull request

Which triplets are supported/not supported?

wasm32-emscripten

github-actions[bot]
github-actions bot previously approved these changes Aug 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/opus/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/opus/vcpkg.json

Valid values for the license field can be found in the documentation

@Adela0814 Adela0814 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Aug 15, 2022
@Adela0814
Copy link
Contributor

Pinging @past-due for response. Is work still being done for this PR? Please fix the conflicts.

@past-due
Copy link
Contributor Author

past-due commented Sep 7, 2022

@Adela0814 Rebased and ready for merge

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Sep 8, 2022
@dan-shaw dan-shaw merged commit 0e9a288 into microsoft:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants