-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rioki-glow] Adds new port glow 0.2.0 #26236
Conversation
Sorry about adding to many commits into the PR; I rebased it to limit it to the glow ones. |
Sorry about running you CI a bit hot... UWP was not on my radar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for rioki-glow have changed but the version was not updated
version: 0.2.0
old SHA: af6fb2a67dcc638ba9f62263ede3ce0f51d2bcb9
new SHA: 7199f209c337e0155cb1be09befe479fd5da724c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for rioki-glow have changed but the version was not updated
version: 0.2.0
old SHA: 7199f209c337e0155cb1be09befe479fd5da724c
new SHA: 0afb47c804b3dc6dbee5924e442d14dc768103ce
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Please hold while I figure out the CMake configure vodoo. |
Tested the usage successfully in my local machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New port checklist:
- Review the code ✅
- Check the name against https://repology.org/ ✅ (Does not exist, but the name chosen is specific enough that it won't get confused)
- Check the name against Bing/Google. (If the first results aren't C++ related, try "name C++") ✅ first result
- Check the source code for optional
find_package
s ✅
find_package(GLEW REQUIRED)
find_package(glm CONFIG REQUIRED)
- Check that the versioning scheme and license match what upstream says ✅
- Check that the source code comes from the upstream project's authoritative source. ✅
- Check that the generated usage is accurate. ✅ Thanks @JonLiu1993
- Check that the reported license is accurate. ✅
Thanks! |
Describe the pull request
What does your PR fix?
Adds the new port of glow, in version 0.2.0
Which triplets are supported/not supported? Have you updated the [CI baseline]
All, yes.
Does your PR follow the maintainer guide?
To the best of my knowledge yes.
The name conflict was discussed here: glow: should I rename my package before submitting to vcpkg? #24676
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/