Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breakpad] Update to 2022.07.12 #26232

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Aug 8, 2022

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Aug 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/breakpad/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 9, 2022
LilyWangLL
LilyWangLL previously approved these changes Aug 9, 2022
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Aug 9, 2022
…IMAGE_RUNTIME_FUNCTION_ENTRY has a member UnwindInfoAddress which is only true on x86 and x64.

(Note that _IMAGE_ARM_RUNTIME_FUNCTION_ENTRY, _IMAGE_ARM64_RUNTIME_FUNCTION_ENTRY, and _IMAGE_ALPHA_RUNTIME_FUNCTION_ENTRY do not have this member)

Simplifying to CNF:
!uwp & !(windows & (arm | arm64 | alpha)) // except of course alpha doesn''t exist
!uwp & (!windows | !(arm | arm64))
!uwp & (!windows | (!arm & !arm64))
!uwp & (!windows | !arm) & (!windows | !arm64)
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/breakpad/vcpkg.json

Valid values for the license field can be found in the documentation

@BillyONeal BillyONeal merged commit 4b4766c into microsoft:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants