Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashrpt] Fix build error #26231

Merged
merged 6 commits into from
Aug 9, 2022

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Aug 8, 2022

Describe the pull request

  • What does your PR fix?

    Fixes [crashrpt] Build error #26171, since the header files path of wtl changed to include/, so crashrpt build failed with fatal error. Adding patch 002-fix-wtl-includepath.patch to fix this issue.
    003-add-definition-UNICODE.patch fix build error use vcpkg_cmake_configure in portfile.cmake:
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.32.31326\ATLMFC\include\atlconv.h(816): error C2440: 'return': cannot convert from 'LPCTSTR' to 'LPCOLESTR'

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 8, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/crashrpt/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/crashrpt/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL marked this pull request as draft August 8, 2022 09:16
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2022
@LilyWangLL LilyWangLL marked this pull request as ready for review August 9, 2022 07:07
JackBoosY
JackBoosY previously approved these changes Aug 9, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 9, 2022
"description": "A crash reporting system for Windows applications",
"homepage": "http://crashrpt.sourceforge.net/",
"license": "BSD-3-Clause-Clear",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clearly isn't https://spdx.org/licenses/BSD-3-Clause-Clear.html; there's no statement about patent rights.

@BillyONeal BillyONeal merged commit e47ff30 into microsoft:master Aug 9, 2022
@BillyONeal
Copy link
Member

Thanks!

@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue26171 branch August 10, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crashrpt] Build error
3 participants