-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crashrpt] Fix build error #26231
[crashrpt] Fix build error #26231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/crashrpt/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/crashrpt/vcpkg.json
Valid values for the license field can be found in the documentation
ports/crashrpt/vcpkg.json
Outdated
"description": "A crash reporting system for Windows applications", | ||
"homepage": "http://crashrpt.sourceforge.net/", | ||
"license": "BSD-3-Clause-Clear", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clearly isn't https://spdx.org/licenses/BSD-3-Clause-Clear.html; there's no statement about patent rights.
3dd4b6c
Thanks! |
Describe the pull request
What does your PR fix?
Fixes [crashrpt] Build error #26171, since the header files path ofwtl
changed toinclude/
, socrashrpt
build failed with fatal error. Adding patch002-fix-wtl-includepath.patch
to fix this issue.003-add-definition-UNICODE.patch
fix build error usevcpkg_cmake_configure
inportfile.cmake
: