Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[botan] Add arm64-windows support #26156

Merged
merged 4 commits into from
Aug 6, 2022
Merged

[botan] Add arm64-windows support #26156

merged 4 commits into from
Aug 6, 2022

Conversation

nursik
Copy link
Contributor

@nursik nursik commented Aug 3, 2022

Describe the pull request

  • What does your PR fix?

    Add botan:arm64-windows

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for botan have changed but the version was not updated
version: 2.19.1#1
old SHA: 5496cee44a01b974ab4ff0085b96cda44d97402e
new SHA: 406799e862c2da6bad298fdd65b561c746f0dd83
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@nursik nursik marked this pull request as ready for review August 3, 2022 21:21
@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 4, 2022
@JonLiu1993
Copy link
Member

@nursik, Thanks for your pr, looks ci test failed in arm_uwp triplet,
this is error log:
build-arm-uwp-rel-out.log
build-arm-uwp-rel-err.log

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for botan have changed but the version was not updated
version: 2.19.1#1
old SHA: 5496cee44a01b974ab4ff0085b96cda44d97402e
new SHA: 46addf1e5297d40d351cf84d2a62d831592df1d1
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@nursik
Copy link
Contributor Author

nursik commented Aug 4, 2022

@JonLiu1993 Removed arm-uwp triplet as the work was intended to enable arm64-windows build

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 5, 2022
@BillyONeal
Copy link
Member

Thanks! Please submit this upstream to https://github.com/randombit/botan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants