Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpgmm] Add gpgmm. Highly experimental. #26045

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

bbernhar
Copy link
Contributor

Reverts #25849

Just disables the backend causing the vulkan dependencies (will be fixed in next release).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gpgmm have changed but the version was not updated
version: 0.0.4
old SHA: 08e07fe17d9d990b3d2579b33c6851b60faa6c2c
new SHA: 2b41a99e8bbc4b9271d1b5d6ffe512e26b8f9da3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2022
@LilyWangLL LilyWangLL self-assigned this Jul 29, 2022
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 29, 2022
ports/gpgmm/portfile.cmake Outdated Show resolved Hide resolved
ports/gpgmm/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gpgmm have changed but the version was not updated
version: 0.0.4
old SHA: 837759b15699a903e302a930f29904f811f7250d
new SHA: 91e6125f3f56420196a48243a54c639cb471ebc2
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2022
@bbernhar bbernhar marked this pull request as ready for review July 30, 2022 03:10
@bbernhar bbernhar requested a review from LilyWangLL July 30, 2022 03:11
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 1, 2022
@bbernhar
Copy link
Contributor Author

bbernhar commented Aug 1, 2022

@LilyWangLL Thank you. Please merge.

@ras0219-msft
Copy link
Contributor

Ok this looks good to me. Looking forward to a de-vendored vulkan backend in the future!

@ras0219-msft ras0219-msft merged commit f06a2f2 into microsoft:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants