-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[arrow] Update to 8.0.1, fix usage #25983
Conversation
Long story short, port arrow is not usable on static triplets, due to lack of passing any lib except for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d052cd6113dbbede9ebc615f1aca5be112a78420 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/arrow.json b/versions/a-/arrow.json
index febcc4f..b00a928 100644
--- a/versions/a-/arrow.json
+++ b/versions/a-/arrow.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "1b536a1afeed635420917954df17d83242892866",
+ "version": "8.0.1",
+ "port-version": 0
+ },
{
"git-tree": "4334074d163357f9002145ca722dc8dbcc546dbc",
"version": "8.0.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index 4772f80..b3eac15 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -177,7 +177,7 @@
"port-version": 0
},
"arrow": {
- "baseline": "8.0.0",
+ "baseline": "8.0.1",
"port-version": 0
},
"ashes": {
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/vcpkg-ci-arrow/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/vcpkg-ci-arrow/vcpkg.json
Valid values for the license field can be found in the documentation
I will add the test port license field when when CI has passed for the arrow port changes. |
FTR tested locally: |
6e997a4
What does your PR fix?
Cleanup.
Updates to 8.0.1.
Fixes build without feature
parquet
.Adds test port for downstream CMake usage.
Fixes exported CMake config.
Fixes invalid items in exported pkg-config, cf. [vcpkg_fixup_pkgconfig] Check for more problems, add unit test #23898 (comment).
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes