Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrow] Update to 8.0.1, fix usage #25983

Merged
merged 15 commits into from
Jul 27, 2022
Merged

[arrow] Update to 8.0.1, fix usage #25983

merged 15 commits into from
Jul 27, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 25, 2022

@LilyWangLL LilyWangLL self-assigned this Jul 26, 2022
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Jul 26, 2022
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 26, 2022

Long story short, port arrow is not usable on static triplets, due to lack of passing any lib except for arrow.
IIUC arrow creates a bundled archive (static lib) from all dependencies for convenience. But I think in vcpkg, it would be better to explicitly pass all dependencies.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d052cd6113dbbede9ebc615f1aca5be112a78420 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/arrow.json b/versions/a-/arrow.json
index febcc4f..b00a928 100644
--- a/versions/a-/arrow.json
+++ b/versions/a-/arrow.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1b536a1afeed635420917954df17d83242892866",
+      "version": "8.0.1",
+      "port-version": 0
+    },
     {
       "git-tree": "4334074d163357f9002145ca722dc8dbcc546dbc",
       "version": "8.0.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index 4772f80..b3eac15 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -177,7 +177,7 @@
       "port-version": 0
     },
     "arrow": {
-      "baseline": "8.0.0",
+      "baseline": "8.0.1",
       "port-version": 0
     },
     "ashes": {

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-arrow/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 26, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-arrow/vcpkg.json

Valid values for the license field can be found in the documentation

@dg0yt dg0yt changed the title [arrow] Update, fix usage [arrow] Update to 8.0.1, fix usage Jul 26, 2022
@dg0yt dg0yt marked this pull request as ready for review July 26, 2022 07:28
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 26, 2022

I will add the test port license field when when CI has passed for the arrow port changes.

github-actions[bot]
github-actions bot previously approved these changes Jul 26, 2022
LilyWangLL
LilyWangLL previously approved these changes Jul 26, 2022
@LilyWangLL LilyWangLL requested a review from JackBoosY July 26, 2022 09:04
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 26, 2022

FTR tested locally:
arrow[core,csv,dataset,example,filesystem,flight,jemalloc,json,mimalloc,parquet,plasma,s3]:x64-linux
(no cuda (not on my machine), no orc (already broken, #25545)).

JackBoosY
JackBoosY previously approved these changes Jul 27, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 27, 2022
@BillyONeal BillyONeal merged commit e20e1c7 into microsoft:master Jul 27, 2022
@dg0yt dg0yt deleted the arrow branch July 27, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants