-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPP] Add new port #25949
[DPP] Add new port #25949
Conversation
can't see logs to find out why this is going wrong... compiled fine for us |
Via the check details, go to Azure Pipelines, then to the artifacts (" published"), then find the download action on the right side while hovering a "failure logs" item. |
ci baseline updated to exclude UWP from tests, set to "fail". this is not a supported platform. |
If UWP is not supported, only add |
I have changed our versioning to our version numbers as requested. |
* Added usage. * Forced pkgconfig to be required rather than quiet. * Changed tabs to spaces in portfile.cmake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very concerned about giving the name "dpp" to this. Repology says that Homebrew already has a "dpp" pointing to https://github.com/atilaneves/dpp which seems to be a different project. However, Google "dpp c++" points to this one conclusively, and that is a tool rather than a library so it wouldn't generally make sense to be a port.
I pushed some nitpick fixes into this; please confirm that you are OK with that @braindigitalis
22ca917
these changes all look good to me. we will have to put these changes into the scripts inside our release ci so when we send an update PR these changes will be preserved (e.g. space indentation and https on the URL). thanks for your time! |
Thank you! |
What does your PR fix?
Adds support for DPP, a lightweight high performance C++ discord library used in multiple large popular Discord bots
Which triplets are supported/not supported? Have you updated the CI baseline?
linux-x64, linux-x86, windows-x64, windows-x86, windows-arm64, osx-x64
CI baseline not updated
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes