Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPP] Add new port #25949

Merged
merged 13 commits into from
Jul 26, 2022
Merged

[DPP] Add new port #25949

merged 13 commits into from
Jul 26, 2022

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Jul 23, 2022

What does your PR fix?

Adds support for DPP, a lightweight high performance C++ discord library used in multiple large popular Discord bots

Which triplets are supported/not supported? Have you updated the CI baseline?

linux-x64, linux-x86, windows-x64, windows-x86, windows-arm64, osx-x64
CI baseline not updated

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@braindigitalis
Copy link
Contributor Author

can't see logs to find out why this is going wrong... compiled fine for us

@dg0yt
Copy link
Contributor

dg0yt commented Jul 24, 2022

can't see logs to find out why this is going wrong... compiled fine for us

Via the check details, go to Azure Pipelines, then to the artifacts (" published"), then find the download action on the right side while hovering a "failure logs" item.

@braindigitalis
Copy link
Contributor Author

ci baseline updated to exclude UWP from tests, set to "fail". this is not a supported platform.

@dg0yt
Copy link
Contributor

dg0yt commented Jul 24, 2022

ci baseline updated to exclude UWP from tests, set to "fail". this is not a supported platform.

If UWP is not supported, only add "supports": "!uwp" to vcpkg.json. The ci baseline list fail is for ports which should work on a user's machine, but can't in vcpkg CI.

github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2022
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 25, 2022
ports/dpp/portfile.cmake Show resolved Hide resolved
ports/dpp/vcpkg.json Outdated Show resolved Hide resolved
@braindigitalis
Copy link
Contributor Author

I have changed our versioning to our version numbers as requested.
the value of NO_PREFIX_CORRECTION is required or cmake will not build and deploy the library correctly.

github-actions[bot]
github-actions bot previously approved these changes Jul 26, 2022
JonLiu1993
JonLiu1993 previously approved these changes Jul 26, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 26, 2022
ports/dpp/vcpkg.json Outdated Show resolved Hide resolved
* Added usage.
* Forced pkgconfig to be required rather than quiet.
* Changed tabs to spaces in portfile.cmake.
BillyONeal
BillyONeal previously approved these changes Jul 26, 2022
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very concerned about giving the name "dpp" to this. Repology says that Homebrew already has a "dpp" pointing to https://github.com/atilaneves/dpp which seems to be a different project. However, Google "dpp c++" points to this one conclusively, and that is a tool rather than a library so it wouldn't generally make sense to be a port.

I pushed some nitpick fixes into this; please confirm that you are OK with that @braindigitalis

@BillyONeal BillyONeal dismissed stale reviews from JonLiu1993, github-actions[bot], and themself via 22ca917 July 26, 2022 18:18
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jul 26, 2022
@braindigitalis
Copy link
Contributor Author

braindigitalis commented Jul 26, 2022

I am very concerned about giving the name "dpp" to this. Repology says that Homebrew already has a "dpp" pointing to https://github.com/atilaneves/dpp which seems to be a different project. However, Google "dpp c++" points to this one conclusively, and that is a tool rather than a library so it wouldn't generally make sense to be a port.

I pushed some nitpick fixes into this; please confirm that you are OK with that @braindigitalis

these changes all look good to me. we will have to put these changes into the scripts inside our release ci so when we send an update PR these changes will be preserved (e.g. space indentation and https on the URL).

thanks for your time!

@BillyONeal BillyONeal merged commit 0257395 into microsoft:master Jul 26, 2022
@BillyONeal
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants