Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Libxpm] ADD new port #25935

Merged
merged 81 commits into from
Sep 8, 2022
Merged

[Libxpm] ADD new port #25935

merged 81 commits into from
Sep 8, 2022

Conversation

vladimir-aubrecht
Copy link
Member

@vladimir-aubrecht vladimir-aubrecht commented Jul 22, 2022

Describe the pull request
This PR is adding Libxpm 3.5.11 port.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    windows, No

  • Does your PR follow the maintainer guide?

    Yes, it follows the rules.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/libxpm/vcpkg.json b/ports/libxpm/vcpkg.json
index edfab710..b009366c 100644
--- a/ports/libxpm/vcpkg.json
+++ b/ports/libxpm/vcpkg.json
@@ -6,12 +6,12 @@
   "license": "MIT",
   "supports": "windows",
   "dependencies": [
-    "xorg-macros",
-    "xproto",
     "libx11",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "xorg-macros",
+    "xproto"
   ]
 }
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libxpm have changed but the version was not updated
version: 3.5.11
old SHA: 42abffc41a14e2463939d1b8470f9faa8c60598b
new SHA: bc20d09daf5ff1cc98c2a8b1b9d4227ca547a84f
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@vladimir-aubrecht
Copy link
Member Author

I have no permission to push to this branch, can you please merge to master first?

Thanks.

I merged with current master, added few missing dependencies, but it's still failing. I'll check it again tomorrow.

I also added you as contributor in case you'd like to do any changes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/libxpm/vcpkg.json b/ports/libxpm/vcpkg.json
index edfab710..b009366c 100644
--- a/ports/libxpm/vcpkg.json
+++ b/ports/libxpm/vcpkg.json
@@ -6,12 +6,12 @@
   "license": "MIT",
   "supports": "windows",
   "dependencies": [
-    "xorg-macros",
-    "xproto",
     "libx11",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "xorg-macros",
+    "xproto"
   ]
 }
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libxpm have changed but the version was not updated
version: 3.5.11
old SHA: 42abffc41a14e2463939d1b8470f9faa8c60598b
new SHA: e5a2e3150c230971b76516e21aeb03f08c0a31c3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libxpm have changed but the version was not updated
version: 3.5.11
old SHA: 6ccd9393c8f4b4ab572a5e956e049914a8f73c75
new SHA: e5a2e3150c230971b76516e21aeb03f08c0a31c3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Aug 31, 2022
JackBoosY added 2 commits August 31, 2022 20:09
ports/libxpm/portfile.cmake Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Sep 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libxpm have changed but the version was not updated
version: 3.5.11
old SHA: efcf31371ac9cd8bf41b1c6c3732963fabeea924
new SHA: 751a045d2a8dd7d287f1b6a4a5041275512e9b8e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 1, 2022
ports/libxpm/vcpkg.json Outdated Show resolved Hide resolved
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libxpm have changed but the version was not updated
version: 3.5.11
old SHA: 751a045d2a8dd7d287f1b6a4a5041275512e9b8e
new SHA: d72a962542b4175f99f5127b477866f2a5eba510
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 6, 2022
@dan-shaw dan-shaw merged commit 3d802bb into microsoft:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants