[curl] Add Unicode support

[rozdaybeda]

Describe the pull request

• What does your PR fix?

  Fixes unicode support for curl

• Which triplets are supported/not supported? Have you updated the CI baseline?

  windows, No

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[ghost]

All CLA requirements met.

[autoantwort]

Suggested change

	if("unicode" IN_LIST FEATURES AND NOT VCPKG_TARGET_IS_WINDOWS)
	message(FATAL_ERROR "Feature 'unicode' is not supported on non-Windows platforms.")
	endif()

[rozdaybeda]

https://github.com/curl/curl/blob/master/CMakeLists.txt

[autoantwort]

Because of that, see my next comment

[Thomas1664]

@rozdaybeda Because you're using "supports": "windows" in vcpkg.json, this is no longer needed and can be removed as proposed by @autoantwort.

[m-kuhn]

Should this be added to default features?

[rozdaybeda]

Should this be added to default features?

I think it should be enabled by default for windows

[JonLiu1993]

@rozdaybeda, Can you please resolve the conflicts against master?

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for curl have changed but the version was not updated
version: 7.84.0#1
old SHA: 4d64a4ac7f080159be045ccbf0a7fa81ef859cfa
new SHA: 1606b7897eff4ebf08becb144b88768a8d5e6236
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

[JonLiu1993]

@rozdaybeda, I agree with @autoantwort, can you revise it?

[JonLiu1993]

@rozdaybeda, These two suggestions should be adopted, what do you think?
#25865 (comment)
#25865 (comment)

[rozdaybeda]

The first one doesn't fit and here's why: #25865
I think it makes sense to add only the second suggestion.

Thanks

[JonLiu1993]

All functions were successfully tested except for feature 'sectransp' in the following triples:

• x86-windows
• x64-windows

[BillyONeal]

I don't believe we can accept this because it's using a feature to control alternatives: https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#do-not-use-features-to-control-alternatives-in-published-interfaces

It may make sense to do unconditionally on Windows (which is why I'm not outright closing the PR).

[BillyONeal]

I don't believe we can accept this because it's using a feature to control alternatives: https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#do-not-use-features-to-control-alternatives-in-published-interfaces

It may make sense to do unconditionally on Windows (which is why I'm not outright closing the PR).

I don't believe anything about this has been addressed.

To be clear, it can never be a requirement for correctness that a feature is not installed.

[rozdaybeda]

@BillyONeal does it work for you?

if(VCPKG_TARGET_IS_WINDOWS)
    list(APPEND OPTIONS -DENABLE_UNICODE=ON)
endif()

Or would that be better?

vcpkg_cmake_configure(
    SOURCE_PATH "${SOURCE_PATH}"
    OPTIONS 
        "-DCMAKE_PROJECT_INCLUDE=${CMAKE_CURRENT_LIST_DIR}/cmake-project-include.cmake"
        ${FEATURE_OPTIONS}
        ${OPTIONS}
        ...
	-DENABLE_UNICODE=ON
    OPTIONS_DEBUG
        -DENABLE_DEBUG=ON
)

[BillyONeal]

@BillyONeal does it work for you?

if(VCPKG_TARGET_IS_WINDOWS)
    list(APPEND OPTIONS -DENABLE_UNICODE=ON)
endif()

It works for me!

@bagder @MarcelRaad @apique Is there any reason we should not just turn this on unconditionally?

[MarcelRaad]

It doesn't do anything on non-Windows platforms, so turning it on unconditionally shouldn't hurt.

[BillyONeal]

Thanks for your contribution @rozdaybeda !