[kf5] Merge copyright files to a single file#25759
Merged
vicroms merged 13 commits intomicrosoft:masterfrom Jul 14, 2022
Merged
[kf5] Merge copyright files to a single file#25759vicroms merged 13 commits intomicrosoft:masterfrom
vicroms merged 13 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/kf5guiaddons/vcpkg.json b/ports/kf5guiaddons/vcpkg.json
index 1d4f299..a497295 100644
--- a/ports/kf5guiaddons/vcpkg.json
+++ b/ports/kf5guiaddons/vcpkg.json
@@ -47,7 +47,6 @@
"name": "qt5-wayland",
"platform": "linux"
}
-
]
}
}PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for kf5guiaddons have changed but the version was not updated
version: 5.89.0#1
old SHA: 6d768a1b5c9419f27a14eb2d0cf64b81bf5b85a0
new SHA: 37f004eb6d5e6377d161abf76991be133c2ad2f1
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5attica/vcpkg.jsonports/kf5auth/vcpkg.jsonports/kf5bookmarks/vcpkg.jsonports/kf5codecs/vcpkg.jsonports/kf5completion/vcpkg.jsonports/kf5config/vcpkg.jsonports/kf5configwidgets/vcpkg.jsonports/kf5coreaddons/vcpkg.jsonports/kf5crash/vcpkg.jsonports/kf5dbusaddons/vcpkg.jsonports/kf5declarative/vcpkg.jsonports/kf5diagram/vcpkg.jsonports/kf5globalaccel/vcpkg.jsonports/kf5guiaddons/vcpkg.jsonports/kf5holidays/vcpkg.jsonports/kf5i18n/vcpkg.jsonports/kf5iconthemes/vcpkg.jsonports/kf5itemmodels/vcpkg.jsonports/kf5itemviews/vcpkg.jsonports/kf5jobwidgets/vcpkg.jsonports/kf5kcmutils/vcpkg.jsonports/kf5kio/vcpkg.jsonports/kf5newstuff/vcpkg.jsonports/kf5notifications/vcpkg.jsonports/kf5package/vcpkg.jsonports/kf5plotting/vcpkg.jsonports/kf5service/vcpkg.jsonports/kf5solid/vcpkg.jsonports/kf5sonnet/vcpkg.jsonports/kf5syntaxhighlighting/vcpkg.jsonports/kf5textwidgets/vcpkg.jsonports/kf5wallet/vcpkg.jsonports/kf5widgetsaddons/vcpkg.jsonports/kf5windowsystem/vcpkg.jsonports/kf5xmlgui/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5attica/vcpkg.jsonports/kf5auth/vcpkg.jsonports/kf5bookmarks/vcpkg.jsonports/kf5codecs/vcpkg.jsonports/kf5completion/vcpkg.jsonports/kf5config/vcpkg.jsonports/kf5configwidgets/vcpkg.jsonports/kf5coreaddons/vcpkg.jsonports/kf5crash/vcpkg.jsonports/kf5dbusaddons/vcpkg.jsonports/kf5declarative/vcpkg.jsonports/kf5diagram/vcpkg.jsonports/kf5globalaccel/vcpkg.jsonports/kf5guiaddons/vcpkg.jsonports/kf5holidays/vcpkg.jsonports/kf5i18n/vcpkg.jsonports/kf5iconthemes/vcpkg.jsonports/kf5itemmodels/vcpkg.jsonports/kf5itemviews/vcpkg.jsonports/kf5jobwidgets/vcpkg.jsonports/kf5kcmutils/vcpkg.jsonports/kf5kio/vcpkg.jsonports/kf5newstuff/vcpkg.jsonports/kf5notifications/vcpkg.jsonports/kf5package/vcpkg.jsonports/kf5plotting/vcpkg.jsonports/kf5service/vcpkg.jsonports/kf5solid/vcpkg.jsonports/kf5sonnet/vcpkg.jsonports/kf5syntaxhighlighting/vcpkg.jsonports/kf5textwidgets/vcpkg.jsonports/kf5wallet/vcpkg.jsonports/kf5widgetsaddons/vcpkg.jsonports/kf5windowsystem/vcpkg.jsonports/kf5xmlgui/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5attica/vcpkg.jsonports/kf5auth/vcpkg.jsonports/kf5bookmarks/vcpkg.jsonports/kf5codecs/vcpkg.jsonports/kf5completion/vcpkg.jsonports/kf5config/vcpkg.jsonports/kf5configwidgets/vcpkg.jsonports/kf5coreaddons/vcpkg.jsonports/kf5crash/vcpkg.jsonports/kf5dbusaddons/vcpkg.jsonports/kf5declarative/vcpkg.jsonports/kf5diagram/vcpkg.jsonports/kf5globalaccel/vcpkg.jsonports/kf5guiaddons/vcpkg.jsonports/kf5holidays/vcpkg.jsonports/kf5i18n/vcpkg.jsonports/kf5iconthemes/vcpkg.jsonports/kf5itemmodels/vcpkg.jsonports/kf5itemviews/vcpkg.jsonports/kf5jobwidgets/vcpkg.jsonports/kf5kcmutils/vcpkg.jsonports/kf5kio/vcpkg.jsonports/kf5newstuff/vcpkg.jsonports/kf5notifications/vcpkg.jsonports/kf5package/vcpkg.jsonports/kf5plotting/vcpkg.jsonports/kf5service/vcpkg.jsonports/kf5solid/vcpkg.jsonports/kf5sonnet/vcpkg.jsonports/kf5syntaxhighlighting/vcpkg.jsonports/kf5textwidgets/vcpkg.jsonports/kf5wallet/vcpkg.jsonports/kf5widgetsaddons/vcpkg.jsonports/kf5windowsystem/vcpkg.jsonports/kf5xmlgui/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5attica/vcpkg.jsonports/kf5auth/vcpkg.jsonports/kf5bookmarks/vcpkg.jsonports/kf5codecs/vcpkg.jsonports/kf5completion/vcpkg.jsonports/kf5config/vcpkg.jsonports/kf5configwidgets/vcpkg.jsonports/kf5coreaddons/vcpkg.jsonports/kf5crash/vcpkg.jsonports/kf5dbusaddons/vcpkg.jsonports/kf5declarative/vcpkg.jsonports/kf5diagram/vcpkg.jsonports/kf5globalaccel/vcpkg.jsonports/kf5guiaddons/vcpkg.jsonports/kf5holidays/vcpkg.jsonports/kf5i18n/vcpkg.jsonports/kf5iconthemes/vcpkg.jsonports/kf5itemmodels/vcpkg.jsonports/kf5itemviews/vcpkg.jsonports/kf5jobwidgets/vcpkg.jsonports/kf5kcmutils/vcpkg.jsonports/kf5kio/vcpkg.jsonports/kf5newstuff/vcpkg.jsonports/kf5notifications/vcpkg.jsonports/kf5package/vcpkg.jsonports/kf5plotting/vcpkg.jsonports/kf5service/vcpkg.jsonports/kf5solid/vcpkg.jsonports/kf5sonnet/vcpkg.jsonports/kf5syntaxhighlighting/vcpkg.jsonports/kf5textwidgets/vcpkg.jsonports/kf5wallet/vcpkg.jsonports/kf5widgetsaddons/vcpkg.jsonports/kf5windowsystem/vcpkg.jsonports/kf5xmlgui/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5attica/vcpkg.jsonports/kf5auth/vcpkg.jsonports/kf5bookmarks/vcpkg.jsonports/kf5codecs/vcpkg.jsonports/kf5completion/vcpkg.jsonports/kf5config/vcpkg.jsonports/kf5configwidgets/vcpkg.jsonports/kf5coreaddons/vcpkg.jsonports/kf5crash/vcpkg.jsonports/kf5dbusaddons/vcpkg.jsonports/kf5declarative/vcpkg.jsonports/kf5diagram/vcpkg.jsonports/kf5globalaccel/vcpkg.jsonports/kf5guiaddons/vcpkg.jsonports/kf5holidays/vcpkg.jsonports/kf5i18n/vcpkg.jsonports/kf5iconthemes/vcpkg.jsonports/kf5itemmodels/vcpkg.jsonports/kf5itemviews/vcpkg.jsonports/kf5jobwidgets/vcpkg.jsonports/kf5kcmutils/vcpkg.jsonports/kf5kio/vcpkg.jsonports/kf5newstuff/vcpkg.jsonports/kf5notifications/vcpkg.jsonports/kf5package/vcpkg.jsonports/kf5plotting/vcpkg.jsonports/kf5service/vcpkg.jsonports/kf5solid/vcpkg.jsonports/kf5sonnet/vcpkg.jsonports/kf5syntaxhighlighting/vcpkg.jsonports/kf5textwidgets/vcpkg.jsonports/kf5wallet/vcpkg.jsonports/kf5widgetsaddons/vcpkg.jsonports/kf5windowsystem/vcpkg.jsonports/kf5xmlgui/vcpkg.json
Valid values for the license field can be found in the documentation
LilyWangLL
added
the
category:port-feature
LilyWangLL
approved these changes
Jul 14, 2022
LilyWangLL
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
All kf5 ports have multiple license files. Previously, they were installed to acopyrightdirectory. This PR disallows this behaviour: Change the copyright post-build-lint to require a regular file. vcpkg-tool#584I'm using the new cmake function
vcpkg_install_copyrightfunction that was added in [vcpkg] Addvcpkg_install_copyright()portfile function #25239.