-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] Update to 9.0.0 #25658
[fmt] Update to 9.0.0 #25658
Conversation
It seems like the |
In #23918, I arrived at updating openimageio. But the PR isn't ready yet. |
Log from x86-windows
|
I'm hoping for a merge soon since I was also getting these annoying warnings lately in Visual Studio 2022: |
@BullyWiiPlaza I'm also eager to get this merged. Though fmt 9 introduced 2 new warnings that have since been fixed but have not been released with a 9.1 or 9.0.1 update yet. The CI failures currently only come from the openimageio port being severely outdated and it currently will not compile with fmt v9. Though, as I'm not too experienced with how vcpkg handles port dependencies, I would like to ask the vcpkg team if there was any way in telling the CI that that port simply won't compile with fmt 9, and have the compile failures be expected? That would get this PR merged, while having openimageio users still be able to use it with the previous version of the fmt port. |
@spnda @BullyWiiPlaza Sorry, we have to wait for |
Now that #23918 has been merged, is this PR being worked on? |
@walge-laine There's nothing for this PR to work on. I'll just trigger the CI to re-run with the changes on master and all of that should succeed. Thanks for reminding me though, I was not subscribed to the other PR. |
@spnda @walge-laine I merged the branch of this pr into the master. Now this PR is working fine, I think we can merge it now. :) |
Thanks for the update! |
Describe the pull request
Updates the fmtlib port to 9.0.0.
What does your PR fix?
Fixes [fmt] update to 9.0.0 #25642.
Which triplets are supported/not supported? Have you updated the CI baseline?
All, No, not required
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes