Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpgmm] Add gpgmm. Highly experimental. #25650

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

bbernhar
Copy link
Contributor

@bbernhar bbernhar commented Jul 8, 2022

Describe the pull request

  • What does your PR fix?

    Adds gpgmm

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@bbernhar bbernhar force-pushed the gpgmm branch 3 times, most recently from a251db3 to c496a04 Compare July 9, 2022 00:47
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 9, 2022
@Adela0814
Copy link
Contributor

@bbernhar
Please update the port's version fields and then run:

vcpkg x-add-version gpgmm

github-actions[bot]
github-actions bot previously approved these changes Jul 13, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gpgmm/portfile.cmake

@bbernhar bbernhar force-pushed the gpgmm branch 4 times, most recently from 1a6877d to 9ba49aa Compare July 13, 2022 04:54
@bbernhar bbernhar marked this pull request as ready for review July 13, 2022 04:56
@bbernhar
Copy link
Contributor Author

@Adela0814 Thanks, PTAL.

scripts/ci.baseline.txt Outdated Show resolved Hide resolved
ports/gpgmm/vcpkg.json Outdated Show resolved Hide resolved
@bbernhar bbernhar requested a review from Adela0814 July 14, 2022 02:31
@bbernhar bbernhar force-pushed the gpgmm branch 3 times, most recently from c93e9df to 399beeb Compare July 14, 2022 04:27
github-actions[bot]
github-actions bot previously approved these changes Jul 14, 2022
Adela0814
Adela0814 previously approved these changes Jul 14, 2022
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Jul 14, 2022
@bbernhar
Copy link
Contributor Author

@Adela0814 Thank you, please merge.

scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@Adela0814 Adela0814 removed the info:reviewed Pull Request changes follow basic guidelines label Jul 15, 2022
@bbernhar bbernhar requested a review from vicroms July 15, 2022 03:10
@bbernhar bbernhar dismissed stale reviews from Adela0814 and github-actions[bot] via f984c55 July 15, 2022 03:13
@bbernhar bbernhar requested a review from Adela0814 July 15, 2022 03:14
@vicroms vicroms added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 15, 2022
@vicroms vicroms merged commit 33c8f02 into microsoft:master Jul 15, 2022

vcpkg_cmake_configure(
SOURCE_PATH ${SOURCE_PATH}
DISABLE_PARALLEL_CONFIGURE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this option here?

Copy link
Contributor Author

@bbernhar bbernhar Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackBoosY I had issues with multiple CMake configurations trying to modify the same directory path (under .\third_party) at the same time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at third_party/CMakeLists.txt, it seems to me that these parts should be disabled (tests) or de-vendored (vk). IIUC this would also remove the need for git.

Copy link
Contributor Author

@bbernhar bbernhar Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt Agreed. Note: tests should already be disabled, it's just de-vendoring vk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants