Skip to content

[gdal] Fix hdf5 dependency#25646

Merged
vicroms merged 2 commits intomicrosoft:masterfrom
dg0yt:gdal-hdf5-cpp
Jul 8, 2022
Merged

[gdal] Fix hdf5 dependency#25646
vicroms merged 2 commits intomicrosoft:masterfrom
dg0yt:gdal-hdf5-cpp

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 8, 2022

  • What does your PR fix?

    GDAL requests CXX support from HDF5 so we must depend on this feature.
    Fixes [gdal] build failure #25645.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    unchanged, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@dg0yt dg0yt mentioned this pull request Jul 8, 2022
@JackBoosY JackBoosY self-assigned this Jul 8, 2022
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jul 8, 2022
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests passed.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 8, 2022
@vicroms vicroms merged commit a8f38e3 into microsoft:master Jul 8, 2022
@dg0yt dg0yt deleted the gdal-hdf5-cpp branch July 10, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[gdal] build failure

3 participants