Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ableton] Fixed ASIO vs. ASIOSDK confusion #25626

Merged
merged 2 commits into from
Jul 12, 2022
Merged

[ableton] Fixed ASIO vs. ASIOSDK confusion #25626

merged 2 commits into from
Jul 12, 2022

Conversation

JoergAtGithub
Copy link
Contributor

@JoergAtGithub JoergAtGithub commented Jul 7, 2022 •
edited
Loading

Describe the pull request

What does your PR fix?

This fixes a failure I did in #25438
I didn't realized, that Ableton Link has two dependencies with similar name ASIO and ASIOSDK, which are completely unrealated:

  • ASIO (ASyncronous IO) is a cross-platform C++ library for network and low-level I/O programming
  • ASIOSDK is the SDK for the Steinberg ASIO (Audio Stream Input/Output) drivers. Used for proffesional Windows audio applications.

Therefore I mangled these in the first version of the port.
Correct is the new behaviour:

  • ASIO is always needed accross all platforms
  • ASIOSDK is only needed, if the feature "hut" is built on Windows platform

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

@JoergAtGithub JoergAtGithub changed the title Fixed ASIO vs. ASIOSDK confusion [ableton] Fixed ASIO vs. ASIOSDK confusion Jul 7, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 7, 2022
View reviewed changes
@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 8, 2022
FrankXie05
FrankXie05 requested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@FrankXie05 FrankXie05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name should be more recognizable

ports/ableton/replace_asiosdk_download_by_vcpkg_asiosdk.patch Show resolved Hide resolved
ports/ableton/portfile.cmake Outdated Show resolved Hide resolved
ports/ableton/portfile.cmake Outdated Show resolved Hide resolved
ports/ableton/portfile.cmake Outdated Show resolved Hide resolved
@JoergAtGithub JoergAtGithub requested a review from FrankXie05 July 11, 2022 20:19
@FrankXie05
Copy link
Contributor

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-stataic

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jul 12, 2022
@vicroms vicroms merged commit 204949b into microsoft:master Jul 12, 2022
@JoergAtGithub
Copy link
Contributor Author

Thank you!

@JoergAtGithub JoergAtGithub deleted the fixabletonlink branch July 12, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoergAtGithub @FrankXie05 @vicroms