Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[urdfdom] Update to 3.1.0 #25591

Merged
merged 36 commits into from
Aug 6, 2022
Merged

[urdfdom] Update to 3.1.0 #25591

merged 36 commits into from
Aug 6, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Jul 5, 2022 •
edited
Loading

Describe the pull request

  • What does your PR fix?

    Update to 3.1.0
    Remove some patches that aren't needed anymore
    Enable build on static only triplets
    Remove x64-windows-static from CI baseline
    dartsim isn't supported on x86 anymore

github-actions[bot]
github-actions bot previously approved these changes Jul 5, 2022
View reviewed changes
@JackBoosY JackBoosY self-assigned this Jul 6, 2022
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jul 6, 2022
@JackBoosY
Copy link
Contributor

Usage issue:

D:\installed\x64-windows\include\urdf_sensor/sensor.h(93): error C2208: 'double': no members defined using this type
D:\installed\x64-windows\include\urdf_sensor/sensor.h(94): error C2208: 'double': no members defined using this type
D:\installed\x64-windows\include\urdf_sensor/sensor.h(102): error C2059: syntax error: '='
D:\installed\x64-windows\include\urdf_sensor/sensor.h(103): error C2059: syntax error: '='

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/urdfdom-headers/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/dartsim/vcpkg.json
  • ports/urdfdom-headers/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/dartsim/vcpkg.json
  • ports/urdfdom-headers/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/dartsim/vcpkg.json
  • ports/urdfdom-headers/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/dartsim/vcpkg.json
  • ports/urdfdom-headers/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Aug 1, 2022
View reviewed changes
JackBoosY
JackBoosY previously approved these changes Aug 1, 2022
View reviewed changes
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 1, 2022
ras0219-msft
ras0219-msft requested changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

ports/dartsim/portfile.cmake Outdated Show resolved Hide resolved
ports/urdfdom-headers/portfile.cmake Outdated Show resolved Hide resolved
ports/urdfdom-headers/portfile.cmake Outdated Show resolved Hide resolved
ports/urdfdom/0002_fix_exports.patch Outdated Show resolved Hide resolved
ports/urdfdom/0005-fix-config.patch Outdated Show resolved Hide resolved
ports/urdfdom/0005-fix-config.patch Outdated Show resolved Hide resolved
ports/urdfdom/portfile.cmake Show resolved Hide resolved
ports/urdfdom/vcpkg.json Outdated Show resolved Hide resolved
ports/urdfdom/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 3, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 3, 2022
View reviewed changes
@JackBoosY JackBoosY requested a review from ras0219-msft August 3, 2022 09:48
ras0219-msft
ras0219-msft requested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ports/urdfdom/vcpkg.json Outdated Show resolved Hide resolved
@Thomas1664 Thomas1664 requested a review from ras0219-msft August 4, 2022 21:09
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 5, 2022
@BillyONeal BillyONeal merged commit 3887833 into microsoft:master Aug 6, 2022
@BillyONeal
Copy link
Member

Thanks!

@Thomas1664 Thomas1664 deleted the urdfdom branch August 6, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JackBoosY JackBoosY JackBoosY left review comments

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@JackBoosY JackBoosY

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thomas1664 @JackBoosY @BillyONeal @ras0219-msft