Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air-ctl] Update to v1.1.2 #25516

Merged
merged 6 commits into from
Jul 5, 2022
Merged

[air-ctl] Update to v1.1.2 #25516

merged 6 commits into from
Jul 5, 2022

Conversation

inie0722
Copy link
Contributor

@inie0722 inie0722 commented Jul 1, 2022

Describe the pull request

  • What does your PR fix?

air-ctl update to v1.1.2

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Jul 1, 2022
@inie0722 inie0722 closed this Jul 1, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 1, 2022
@inie0722 inie0722 closed this Jul 1, 2022
@JonLiu1993 JonLiu1993 self-assigned this Jul 1, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 1, 2022
@JonLiu1993
Copy link
Member

CI test error but not caused by this port:

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:14 (message):
  

  File does not have expected hash:

          File path: [ D:/downloads/inie0722-CTL-v1.1.2.tar.gz ]
      Expected hash: [ 5669db0448359023cc55b0f9134084cda3aea716996d58ef7e8e63d3721c074af27f59a52c1976c72decea93630f64c463718344f34fdae3e5a832c9d876913a ]
        Actual hash: [ e44d978875e030ded9a40687063f5fc9624307942ff2f2c40aad334c280c04464198f7a784c28206a8b328fc9f9ea26cf3e095bac44bede2522513b0d16e56b1 ]

  The cached file SHA512 doesn't match.  The file may have been corrupted.
  To re-download this file please delete cached file at path
  D:/downloads/inie0722-CTL-v1.1.2.tar.gz and retry.

@inie0722
Copy link
Contributor Author

inie0722 commented Jul 1, 2022

CI may read the previous cache.

@JonLiu1993
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 4, 2022
@vicroms
Copy link
Member

vicroms commented Jul 5, 2022

There was probably another PR at some point for this version(?).

Seems weird to me that we had a cache conflict while using vcpkg_from_github. This means we should probably take a look at how temporary file names under the hood to prevent this from happening again.

P.S.: Upstream changing the contents of tags is the reason we use full commit hashes as REF instead of just version tags.

@vicroms vicroms merged commit e71df97 into microsoft:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants