[proxy] Add new port #25445

tian-lt · 2022-06-27T06:02:28Z

Describe the pull request

What does your PR fix?

No, this PR is going to add a new port - proxy, which is referring to a GitHub repo: https://github.com/microsoft/proxy
Which triplets are supported/not supported? Have you updated the CI baseline?

all, No.
(This is a header-only library
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

Cc @mingxwa

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/proxy/vcpkg.json b/ports/proxy/vcpkg.json
index 694aeed..06f3072 100644
--- a/ports/proxy/vcpkg.json
+++ b/ports/proxy/vcpkg.json
@@ -1,6 +1,6 @@
 {
-    "name": "proxy",
-    "version-string": "1.0.0",
-    "description": "Proxy: Easy Polymorphism in C++",
-    "homepage": "https://github.com/microsoft/proxy"
+  "name": "proxy",
+  "version-string": "1.0.0",
+  "description": "Proxy: Easy Polymorphism in C++",
+  "homepage": "https://github.com/microsoft/proxy"
 }

Use the version scheme "version" instead of "version-string" in port "proxy".

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c168ce4e765409509c9c482faa0468c4e1ab386b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6de3d7c..ecf0c6a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5644,6 +5644,10 @@
       "baseline": "1.7.1",
       "port-version": 0
     },
+    "proxy": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "proxygen": {
       "baseline": "2022.03.21.00",
       "port-version": 2

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/proxy/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/proxy/vcpkg.json

Valid values for the license field can be found in the documentation

…s/proxy

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/proxy/vcpkg.json b/ports/proxy/vcpkg.json
index 694aeed..06f3072 100644
--- a/ports/proxy/vcpkg.json
+++ b/ports/proxy/vcpkg.json
@@ -1,6 +1,6 @@
 {
-    "name": "proxy",
-    "version-string": "1.0.0",
-    "description": "Proxy: Easy Polymorphism in C++",
-    "homepage": "https://github.com/microsoft/proxy"
+  "name": "proxy",
+  "version-string": "1.0.0",
+  "description": "Proxy: Easy Polymorphism in C++",
+  "homepage": "https://github.com/microsoft/proxy"
 }

Use the version scheme "version" instead of "version-string" in port "proxy".

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c168ce4e765409509c9c482faa0468c4e1ab386b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6de3d7c..ecf0c6a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5644,6 +5644,10 @@
       "baseline": "1.7.1",
       "port-version": 0
     },
+    "proxy": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "proxygen": {
       "baseline": "2022.03.21.00",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/proxy/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/proxy/vcpkg.json b/ports/proxy/vcpkg.json
index 6dce0ee..6ddbef2 100644
--- a/ports/proxy/vcpkg.json
+++ b/ports/proxy/vcpkg.json
@@ -1,16 +1,16 @@
 {
-    "name": "proxy",
-    "version-string": "1.0.1",
-    "description": "Proxy: Easy Polymorphism in C++",
-    "homepage": "https://github.com/microsoft/proxy",
-    "dependencies": [
-        {
-            "name": "vcpkg-cmake",
-            "host": true
-        },
-        {
-            "name": "vcpkg-cmake-config",
-            "host": true
-        }
-    ]
+  "name": "proxy",
+  "version-string": "1.0.1",
+  "description": "Proxy: Easy Polymorphism in C++",
+  "homepage": "https://github.com/microsoft/proxy",
+  "dependencies": [
+    {
+      "name": "vcpkg-cmake",
+      "host": true
+    },
+    {
+      "name": "vcpkg-cmake-config",
+      "host": true
+    }
+  ]
 }

Use the version scheme "version" instead of "version-string" in port "proxy".

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c168ce4e765409509c9c482faa0468c4e1ab386b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6de3d7c..56573a7 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5644,6 +5644,10 @@
       "baseline": "1.7.1",
       "port-version": 0
     },
+    "proxy": {
+      "baseline": "1.0.1",
+      "port-version": 0
+    },
     "proxygen": {
       "baseline": "2022.03.21.00",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/proxy/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c168ce4e765409509c9c482faa0468c4e1ab386b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6de3d7c..56573a7 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5644,6 +5644,10 @@
       "baseline": "1.7.1",
       "port-version": 0
     },
+    "proxy": {
+      "baseline": "1.0.1",
+      "port-version": 0
+    },
     "proxygen": {
       "baseline": "2022.03.21.00",
       "port-version": 2

ports/proxy/vcpkg.json

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for proxy have changed but the version was not updated
version: 1.0.1
old SHA: bddf6120102dc63a5bf807cd16b70834799c382b
new SHA: 0ba577da463784a45333a8a1f77bb70294b72441
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Adela0814 · 2022-06-29T10:18:16Z

@tian-lt Thanks for your PR! feel free to ping us if the PR is ready for review.

tian-lt · 2022-06-29T13:19:17Z

@Adela0814 thank you for reminding.
Marked this PR as ready for review.

mingxwa · 2022-06-30T06:17:53Z

@Adela0814 I saw the tag "requires:author-response" was added. Which comment are you referring to? Is there any other information required from our side?

cc @tian-lt @BillyONeal

ports/proxy/portfile.cmake

Adela0814 · 2022-06-30T08:13:29Z

@Adela0814 I saw the tag "requires:author-response" was added. Which comment are you referring to? Is there any other information required from our side?

cc @tian-lt @BillyONeal

I'm so sorry, I just found out that my previous comment submission failed.

new port - proxy

b30910b

github-actions bot requested changes Jun 27, 2022

View reviewed changes

tian-lt added 2 commits June 27, 2022 14:05

Merge branch 'master' of https://github.com/microsoft/vcpkg into port…

c79fc40

…s/proxy

replace deprecated tools

cd3441b

github-actions bot requested changes Jun 27, 2022

View reviewed changes

JonLiu1993 assigned Adela0814 Jun 27, 2022

update vcpkg.json

ec9a21b

github-actions bot requested changes Jun 27, 2022

View reviewed changes

resolve comments

9eb99f6

github-actions bot requested changes Jun 27, 2022

View reviewed changes

run ./vcpkg x-add-version --all

380091e

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 27, 2022

mingxwa reviewed Jun 27, 2022

View reviewed changes

ports/proxy/vcpkg.json Outdated Show resolved Hide resolved

update description

b64de25

tian-lt dismissed github-actions[bot]’s stale review via b64de25 June 27, 2022 12:49

github-actions bot requested changes Jun 27, 2022

View reviewed changes

mingxwa previously approved these changes Jun 27, 2022

View reviewed changes

update git-tree

5165ece

tian-lt dismissed mingxwa’s stale review via 5165ece June 27, 2022 12:53

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

mingxwa previously approved these changes Jun 27, 2022

View reviewed changes

tian-lt marked this pull request as ready for review June 29, 2022 13:18

Adela0814 added the requires:author-response label Jun 30, 2022

Adela0814 suggested changes Jun 30, 2022

View reviewed changes

ports/proxy/portfile.cmake Outdated Show resolved Hide resolved

add quotes

6ada677

run vcpkg x-add-version --all

f9c9915

tian-lt dismissed stale reviews from mingxwa and github-actions[bot] via f9c9915 June 30, 2022 08:32

github-actions bot approved these changes Jun 30, 2022

View reviewed changes

tian-lt requested a review from Adela0814 June 30, 2022 08:33

Adela0814 approved these changes Jun 30, 2022

View reviewed changes

Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 30, 2022

dan-shaw merged commit ec547c1 into microsoft:master Jun 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[proxy] Add new port #25445

[proxy] Add new port #25445

tian-lt commented Jun 27, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

Adela0814 commented Jun 29, 2022

tian-lt commented Jun 29, 2022

mingxwa commented Jun 30, 2022

Adela0814 commented Jun 30, 2022

[proxy] Add new port #25445

[proxy] Add new port #25445

Conversation

tian-lt commented Jun 27, 2022 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Adela0814 commented Jun 29, 2022

tian-lt commented Jun 29, 2022

mingxwa commented Jun 30, 2022

Adela0814 commented Jun 30, 2022

tian-lt commented Jun 27, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?