-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Rewrite doc for vcpkg_cmake_configure. Move up into docs/maintainers/. #25255
Merged
ras0219-msft
merged 4 commits into
microsoft:master
from
ras0219-msft:dev/roschuma/docs-vcpkg-cmake
Jun 29, 2022
Merged
[docs] Rewrite doc for vcpkg_cmake_configure. Move up into docs/maintainers/. #25255
ras0219-msft
merged 4 commits into
microsoft:master
from
ras0219-msft:dev/roschuma/docs-vcpkg-cmake
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicroms
previously approved these changes
Jun 16, 2022
LilyWangLL
added
the
category:documentation
To resolve the issue, documentation will need to be updated
label
Jun 16, 2022
LilyWangLL
requested changes
Jun 16, 2022
LilyWangLL
added
requires:author-response
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Jun 16, 2022
ras0219-msft
commented
Jun 16, 2022
ras0219-msft
commented
Jun 16, 2022
ras0219-msft
commented
Jun 16, 2022
@@ -71,7 +71,7 @@ | |||
### [vcpkg-cmake](ports/vcpkg-cmake.md) | |||
|
|||
- [vcpkg\_cmake\_build](ports/vcpkg-cmake/vcpkg_cmake_build.md) | |||
- [vcpkg\_cmake\_configure](ports/vcpkg-cmake/vcpkg_cmake_configure.md) | |||
- [vcpkg\_cmake\_configure](vcpkg_cmake_configure.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be merged into the list above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, yes
ras0219-msft
commented
Jun 16, 2022
vicroms
requested changes
Jun 23, 2022
LGTM after the minor change I suggested. |
…roschuma/docs-vcpkg-cmake
ras0219-msft
force-pushed
the
dev/roschuma/docs-vcpkg-cmake
branch
from
June 28, 2022 19:41
37a64de
to
7aa9554
Compare
vicroms
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:documentation
To resolve the issue, documentation will need to be updated
info:internal
This PR or Issue was filed by the vcpkg team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first docs overhaul PR for a helper function from a port.
A key change I propose for the port-based helpers is to de-segregate them from the "built-in" helpers and instead rely on documentation within the page to guide users on how to consume it. This change accomplishes two goals: