[skia] Build configuration fix#25247
Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom Jun 17, 2022
Merged
Conversation
|
|
JonLiu1993
added
the
category:port-bug
JonLiu1993
reviewed
Jun 15, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
approved these changes
Jun 16, 2022
Contributor
|
I have tested the usage locally |
JonLiu1993
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [skia] Build failure #25100 and partially [skia] Two build errors #24719
Which triplets are supported/not supported? Have you updated the CI baseline?
No changes
Does your PR follow the maintainer guide?
Probably.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?I ran it now and it didn't do anything.