[wtl] Add another post-release update#25229
Merged
dan-shaw merged 7 commits intomicrosoft:masterfrom Jun 17, 2022
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
reviewed
Jun 15, 2022
JackBoosY
added
info:internal
category:port-update
chrullrich
force-pushed
the
wtl-post-10320-update-3
branch
from
8975afa to
cf62e7b
Compare
JackBoosY
reviewed
Jun 15, 2022
This reverts commit 1d9c1d6.
JackBoosY
approved these changes
Jun 17, 2022
JackBoosY
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds another WTL post-release update (change
<>includes inatlribbon.hto"").It also reverts #25108 by moving the WTL includes back into the
include/wtldirectory.Rationale: #25108 will break all projects using WTL via vcpkg at their next
vcpkg upgrade. This change was made only five days ago and has not yet caused a flood of bug reports regarding broken WTL installations. Therefore it appears useful to put the WTL includes back where they belong and avoid that flood. The prior change was grounded in the incorrect assumption that WTL's choice of include syntax indicated their preference for the location of the WTL include files. Upstream has since clarified that the use of<>includes instead of""was indeed a bug.Which triplets are supported/not supported? Have you updated the CI baseline?
Same as before, and no change required.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.