[check] Fix the incorrect path of dll#25211
Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom Jun 13, 2022
Merged
Conversation
Cheney-W
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/check/vcpkg.json(has deprecated licenseLGPL-2.1)
Deprecated and non deprecated license identifiers can be found here
LilyWangLL
approved these changes
Jun 13, 2022
added 2 commits
June 13, 2022 03:11
LilyWangLL
added
the
info:needs-maintainer-attention
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Fixes [check] checkShared produce broken binaries #25181
The dll file can not be stored in the manual-link folder.
No feature need to test.