Skip to content

[paho-mqtt] Update to 1.3.10 and fix include path#25207

Merged
vicroms merged 10 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/issue15349
Jun 15, 2022
Merged

[paho-mqtt] Update to 1.3.10 and fix include path#25207
vicroms merged 10 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/issue15349

Conversation

@LilyWangLL
Copy link
Contributor

Describe the pull request

  1. Update paho-mqtt to version 1.3.10
  2. Remove old patch remove_compiler_options.patch.
  3. Remove patch fix-install-path.patch, due to the official header file path doesn't include port name. This patch be removed, port paho-mqttpp3 doesn't need patch fix-include-path.patch.
  4. Add find_dependency(OpenSSL) for paho-mqtt.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal category:port-update The issue is with a library, which is requesting update new revision labels Jun 13, 2022
Copy link
Contributor

@Thomas1664 Thomas1664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is still a draft, I have a few suggestions:

@LilyWangLL LilyWangLL marked this pull request as ready for review June 13, 2022 09:57
@LilyWangLL LilyWangLL requested a review from JackBoosY June 15, 2022 08:43
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 15, 2022
@vicroms vicroms merged commit 9641449 into microsoft:master Jun 15, 2022
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue15349 branch June 27, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[paho-mqtt] wrong include path

5 participants